Bug#812155: release.debian.org: Patch to make heidi output optional

[Robert Bruce Park <robert.park@canonical.com>]

Package: release.debian.org
Severity: wishlist
Tags: patch
User: release.debian.org@packages.debian.org
Usertags: britney

Hi, I'm doing some work on britney as used by ubuntu and I've made Heidi output optional as we were not using it in all cases, in the hopes of saving some time/disk space.

Please consider the attached patch, thanks.



-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-5-generic (SMP w/8 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

=== modified file 'britney.py'
--- britney.py	2016-01-19 20:05:32 +0000
+++ britney.py	2016-01-20 02:17:12 +0000
@@ -453,7 +453,7 @@
                          not getattr(self.options, k.lower()):
                         setattr(self.options, k.lower(), v)
 
-        if not hasattr(self.options, "heidi_delta_output"):
+        if self.options.heidi_output and not hasattr(self.options, "heidi_delta_output"):
             self.options.heidi_delta_output = self.options.heidi_output + "Delta"
 
         self.options.nobreakall_arches = self.options.nobreakall_arches.split()
@@ -3023,14 +3023,15 @@
             except AttributeError:
                 self.write_dates(self.options.testing, self.dates)
 
-            # write HeidiResult
-            self.__log("Writing Heidi results to %s" % self.options.heidi_output)
-            write_heidi(self.options.heidi_output, self.sources["testing"],
-                        self.binaries["testing"])
+            if self.options.heidi_output:
+                # write HeidiResult
+                self.__log("Writing Heidi results to %s" % self.options.heidi_output)
+                write_heidi(self.options.heidi_output, self.sources["testing"],
+                            self.binaries["testing"])
 
-            self.__log("Writing delta to %s" % self.options.heidi_delta_output)
-            write_heidi_delta(self.options.heidi_delta_output,
-                              self.all_selected)
+                self.__log("Writing delta to %s" % self.options.heidi_delta_output)
+                write_heidi_delta(self.options.heidi_delta_output,
+                                  self.all_selected)
 
 
         self.printuninstchange()