[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#794486: marked as done (release.debian.org: auto transition trackers incorrectly handle addition of suffixes (including GCC 5 related transitions))

Your message dated Fri, 06 Nov 2015 11:20:56 +0000
with message-id <1446808856.2080.6.camel@adam-barratt.org.uk>
and subject line Re: Bug#794486: release.debian.org: auto transition trackers incorrectly handle addition of suffixes (including GCC 5 related transitions)
has caused the Debian Bug report #794486,
regarding release.debian.org: auto transition trackers incorrectly handle addition of suffixes (including GCC 5 related transitions)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
794486: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=794486
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertags: tools

Hi,

I don't think any of the automatic transition trackers for the
libstdcxx / GCC 5 packages are working correctly.

Currently cmake has been rebuilt against both the new versions of GCC 5
and libjsoncpp, and shows up good on this tracker:
https://release.debian.org/transitions/html/libstdc++6.html

but bad on this tracker:
https://release.debian.org/transitions/html/auto-libjsoncpp.html

The auto-libjsoncpp ben file contains this:
is_affected = .depends ~ /libjsoncpp0v5|libjsoncpp0v5\-dbg|libjsoncpp0|libjsoncpp0\-dbg/;
is_good = .depends ~ /libjsoncpp0v5|libjsoncpp0v5\-dbg/;
is_bad = .depends ~ /libjsoncpp0|libjsoncpp0\-dbg/;

Here, packages depending on libjsoncpp0v5 match both the is_good and
is_bad regexes so ben marks them as bad.

The regexes for is_good and is_bad should probably have ^ and $
inserted before and after each package name to fix this.

Thanks,
James

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message --- 
On Mon, 2015-08-03 at 18:50 +0200, Julien Cristau wrote:
> On Mon, Aug  3, 2015 at 17:34:20 +0100, James Cowgill wrote:
> 
> > On Mon, 2015-08-03 at 18:09 +0200, Julien Cristau wrote:
> > > On Mon, Aug  3, 2015 at 16:44:32 +0100, James Cowgill wrote:
[...]
> > > > I don't think any of the automatic transition trackers for the
> > > > libstdcxx / GCC 5 packages are working correctly.
[...]
> > > > Here, packages depending on libjsoncpp0v5 match both the is_good and
> > > > is_bad regexes so ben marks them as bad.
> > > > 
> > > I've made a manual tracker for libjsoncpp, see
> > > https://release.debian.org/transitions/html/libjsoncpp.html
> > 
> > That looks better. I tried one I suggested with ^ and $ and it didn't
> > work properly, so I guess ben applies the regex to the entire Depends
> > line? The automatic solution could be a little more complex than I
> > thought.
> > 
> Right; adding \b instead might work.

That was implemented a little while ago:

commit a77b740931d962a68a61d5eb3fb37d36ed9a0a09
Author: Adam D. Barratt <adam@adam-barratt.org.uk>
Date:   Tue Aug 4 19:49:29 2015 +0100

    auto-transitioner: make regex matches more exact
    
    Bracketing the expressions with \b avoids issues with e.g. bad
    containing libfoo1 and good containing libfoo11
    
    Signed-off-by: Adam D. Barratt <adam@adam-barratt.org.uk>

Regards,

Adam

--- End Message ---
Reply to: