[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#779534: marked as done (unblock: scummvm/1.7.0+dfsg-2)

Your message dated Mon, 02 Mar 2015 19:13:30 +0100
with message-id <54F4A84A.6050301@thykier.net>
and subject line Re: Bug#779534: unblock: scummvm/1.7.0+dfsg-2
has caused the Debian Bug report #779534,
regarding unblock: scummvm/1.7.0+dfsg-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
779534: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779534
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package scummvm

Dear release team,

it was discovered that ScummVM crashed on ARM platforms due to buggy
asm optimizations which made the engine unusable. The issue was resolved by
disabling those optimizations during build time.

This is Debian bug

https://bugs.debian.org/779029

Debdiff is attached.

Regards,

Markus

unblock scummvm/1.7.0+dfsg-2

-- System Information:
Debian Release: 8.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru scummvm-1.7.0+dfsg/debian/changelog scummvm-1.7.0+dfsg/debian/changelog
--- scummvm-1.7.0+dfsg/debian/changelog	2014-08-09 17:10:20.000000000 +0200
+++ scummvm-1.7.0+dfsg/debian/changelog	2015-02-28 18:52:30.000000000 +0100
@@ -1,3 +1,15 @@
+scummvm (1.7.0+dfsg-2) unstable; urgency=medium
+
+  * Team upload.
+  * Add disable-arm-asm.patch.
+    Fix a crash and segmentation fault on ARM systems by disabling asm
+    optimizations.
+    Thanks to Konstantinos Margaritis <markos@freevec.org> for the report
+    and patch and Vagrant Cascadian for further testing.
+    (Closes: #779029)
+
+ -- Markus Koschany <apo@gambaru.de>  Sat, 28 Feb 2015 18:50:52 +0100
+
 scummvm (1.7.0+dfsg-1) unstable; urgency=low
 
   * New upstream release [July 2014].
diff -Nru scummvm-1.7.0+dfsg/debian/patches/disable-arm-asm.patch scummvm-1.7.0+dfsg/debian/patches/disable-arm-asm.patch
--- scummvm-1.7.0+dfsg/debian/patches/disable-arm-asm.patch	1970-01-01 01:00:00.000000000 +0100
+++ scummvm-1.7.0+dfsg/debian/patches/disable-arm-asm.patch	2015-02-28 18:52:30.000000000 +0100
@@ -0,0 +1,32 @@
+From: Konstantinos Margaritis <markos@freevec.org>
+Date: Sat, 28 Feb 2015 18:46:02 +0100
+Subject: disable arm asm
+
+Disable asm optimizatons for ARM sytems to prevent a crash and
+segmentation fault when running ScummVM on these platforms.
+
+Forwarded: http://sourceforge.net/p/scummvm/bugs/6810/
+Bug-Debian: https://bugs.debian.org/779029
+---
+ configure | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/configure b/configure
+index 0635907..d3391e7 100755
+--- a/configure
++++ b/configure
+@@ -2027,10 +2027,10 @@ echo_n "Checking host CPU architecture... "
+ case $_host_cpu in
+ 	arm*)
+ 		echo "ARM"
+-		define_in_config_if_yes yes 'USE_ARM_SCALER_ASM'
+-		define_in_config_if_yes yes 'USE_ARM_SOUND_ASM'
+-		define_in_config_if_yes yes 'USE_ARM_SMUSH_ASM'
+-		define_in_config_if_yes yes 'USE_ARM_GFX_ASM'
++		# define_in_config_if_yes yes 'USE_ARM_SCALER_ASM'
++		# define_in_config_if_yes yes 'USE_ARM_SOUND_ASM'
++		# define_in_config_if_yes yes 'USE_ARM_SMUSH_ASM'
++		# define_in_config_if_yes yes 'USE_ARM_GFX_ASM'
+ 		# FIXME: The following feature exhibits a bug during the intro scene of Indy 4
+ 		# (on Pandora and iPhone at least)
+ 		#define_in_config_if_yes yes 'USE_ARM_COSTUME_ASM'
diff -Nru scummvm-1.7.0+dfsg/debian/patches/series scummvm-1.7.0+dfsg/debian/patches/series
--- scummvm-1.7.0+dfsg/debian/patches/series	2014-08-09 16:16:00.000000000 +0200
+++ scummvm-1.7.0+dfsg/debian/patches/series	2015-02-28 18:52:30.000000000 +0100
@@ -1 +1,2 @@
 drop1test.patch
+disable-arm-asm.patch

--- End Message ---
--- Begin Message --- 
On 2015-03-01 23:27, Markus Koschany wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package scummvm
> 
> Dear release team,
> 
> it was discovered that ScummVM crashed on ARM platforms due to buggy
> asm optimizations which made the engine unusable. The issue was resolved by
> disabling those optimizations during build time.
> 
> This is Debian bug
> 
> https://bugs.debian.org/779029
> 
> Debdiff is attached.
> 
> Regards,
> 
> Markus
> 
> unblock scummvm/1.7.0+dfsg-2
> 
> [...]

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: