--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Hi,
Summary:
ocl-icd contains a testsuite that fails on mips64el because
one of its test programs do not use the correct ABI. I would like your
approval to prepare a package that desactivate this test.
In details:
ocl-icd is an OpenCL ICD loader, that is (mainly) a shared library that
dlopens other libraries (real OpenCL implementations) and dispatches all
OpenCL application calls to loaded real OpenCL implementations.
In one test of its testsuite, the ICD loader is tried with a fake
OpenCL implementation. This fake implementation only display the name
of the function called and is only used internally during the build.
For this reason, the test application do not use the real prototype of
OpenCL function but, instead, it casts all calls to a simple prototype
(from memory (void)(*)(struct fake_struct*) or something similar).
In #774876, the reporter analysed that this cast leads to spurious
writes on the stack on the mipsel64 architecture and the testsuite fails.
The correct fix would be to use the correct prototype. It is not so easy
because, currently, test program and fake OpenCL implementation are
automaticcaly generated.
So, I would like your approval to desactivate this test in the package.
If you agree, I plan to do this only for the mips64* architectures
as the hack seems to work on other architecture for now.
PS: lintian tells me the package is still at policy 3.9.5 instead of 3.9.6.
Would it be correct to also change this in debian/control (no other changes
are required)?
Regards,
Vincent
Current debdiff (I will check the reporter that that package build fine on
mip64* with this modification)
========================
diff -Nru ocl-icd-2.2.3/debian/changelog ocl-icd-2.2.3/debian/changelog
--- ocl-icd-2.2.3/debian/changelog 2014-10-05 17:07:47.000000000 +0200
+++ ocl-icd-2.2.3/debian/changelog 2015-01-09 16:09:41.000000000 +0100
@@ -1,3 +1,11 @@
+ocl-icd (2.2.3-2) unstable; urgency=medium
+
+ * Disabling test 5 in the testsuite that generate an error on mips64*
+ architectures due to the use of alternative (simple) prototypes in the test
+ (Closes: #774876)
+
+ -- Vincent Danjean <vdanjean@debian.org> Fri, 09 Jan 2015 15:57:59 +0100
+
ocl-icd (2.2.3-1) unstable; urgency=medium
* New upstream release
diff -Nru ocl-icd-2.2.3/debian/rules ocl-icd-2.2.3/debian/rules
--- ocl-icd-2.2.3/debian/rules 2014-10-05 17:07:47.000000000 +0200
+++ ocl-icd-2.2.3/debian/rules 2015-01-09 16:09:41.000000000 +0100
@@ -20,6 +20,13 @@
dh_auto_configure -- --disable-debug --disable-update-database \
--enable-official-khronos-headers
+DEB_HOST_ARCH:=$(shell dpkg-architecture -qDEB_HOST_ARCH)
+ifneq ($(filter mips64%,$(DEB_HOST_ARCH)),)
+.PHONY: override_dh_auto_test
+override_dh_auto_test:
+ dh_auto_test -- TESTSUITEFLAGS="-4 6-"
+endif
+
.PHONY: override_dh_shlibdeps
override_dh_shlibdeps:
dh_shlibdeps -a -- --warnings=7
========================
unblock ocl-icd/2.2.3-2
-- System Information:
Debian Release: 8.0
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armel, mipsel
Kernel: Linux 3.18.0-trunk-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
--- End Message ---
--- Begin Message ---
On 2015-01-09 18:35, Adam D. Barratt wrote:
Control: tags -1 + moreinfo
Hi,
On Fri, 2015-01-09 at 16:17 +0100, Vincent Danjean wrote:
ocl-icd contains a testsuite that fails on mips64el because
one of its test programs do not use the correct ABI. I would like your
approval to prepare a package that desactivate this test.
Given that there aren't any mips64* architectures in Debian currently,
I'm afraid that I don't believe this meets the current freeze criteria.
I'm not closing the request right away, in case anyone else is feeling
more generous.
Apparently no-one is.
Regards,
Adam
--- End Message ---