[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#774519: unblock: netscript-2.4/5.4.8



Control: tag -1 moreinfo

On Sun, Jan 04, 2015 at 10:41:18AM +1300, Matthew Grant wrote:
> 2 serious bugs have been fixed in 5.4.8:
> 
> #717871  netscript: fails to install due to insserv rejecting the script
> header: There is a loop between service networking and netscript if started
> 
> This is due to the ifupdown providing insserv support for $network, and
> netscript-2.4 also doing the same.  Both packages configure networking.  The
> setting for $network is configured in /etc/insserv/insserv.conf, but there is
> no way of overriding that, is there?
> 
> This is fixed by removing init.d support for insserv/sysvinit, and depending on
> systemd-sysv

This is an interesting problem. You already conflict with ifupdown, and I'm
not all that keen on requiring systemd as an alternative to fixing that
loop.

On my system at least, /etc/insserv.conf defines network as follows:

  $network  +networking +ifupdown

so ifupdown is already optional. Can you not ship a snippet in
/etc/insserv.conf.d that overrides that to something like:

  $network  +networking +ifupdown +netscript

or have I misunderstood the problem?

I suspect ifupdown will have to be purged, not merely removed, to resolve
the loop properly, or the override not include +ifupdown. Note that I've
never tried to do this, I'm just going by the documentation.

> #773772/#773773  netscript-2.4: Interace names with '-' in them cannot be set
> up, and network configuration fails.
> 
> Netscript overloads variable names by adding the interface name at the start.
> '-' are not acceptable parts of /bin/bash environment variable names.  The
> changes for this convert '-' in interface names to '_', which also should be
> done to interface names in /etc/netscript/network.conf
> 
> This bug was fixed in 5.4.7 and I forgot to put a 'Closes' in the changelog and
> had to close #773772/3 via the bugs.debian.org control interface.

Those bugs are indeed closed, but you haven't given the BTS any versioning
information so they still affect version 5.4.8. Until that's fixed it won't
migrate.

> A small fix involving quoting misplacement to do with bridge configuration is
> also in 5.4.8.  I know this is a minor change that fixes an 'Important' level
> bug I found.

Mm, ok.



-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Attachment: signature.asc
Description: Digital signature


Reply to: