[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#650132: hint: binary to source mapping has unhelpful side-effects



On Fri, Dec  4, 2015 at 19:09:47 +0000, Adam D. Barratt wrote:

> diff --git a/scripts/hint b/scripts/hint
> index 9d38274..3b3b1ee 100755
> --- a/scripts/hint
> +++ b/scripts/hint
> @@ -513,9 +513,11 @@ class Hint(object):
>  
>      ##
>  
> -    def __init__(self, hintname, *args):
> +    def __init__(self, hintname, *args, **kwargs):

I'd prefer an explicit 'update' kwarg, defaulting to True.  That'd not
give the impression that we're going to do anything with arbitrary
kwargs, be more self-documenting, and avoid a 'noupdate=False' confusing
double negation.

Thanks,
Julien

Attachment: signature.asc
Description: PGP signature


Reply to: