Re: Request for permission to upload MariaDB 10.0.19 with debian/* bugfixes and security fixes together
Hello!
Ok, thanks for the review. If I revert the two bug fixes commented by
Julien below from the jessie branch, and nobody comments in X days,
then it is OK to upload 10.0.19 to Jessie?
2015-06-19 8:12 GMT+03:00 Julien Cristau <jcristau@debian.org>:
> On Fri, Jun 19, 2015 at 00:12:52 +0300, Otto Kekäläinen wrote:
>
>> > + * Security: improved hardening flags (hardening=+all,-pie)
>> >
>> > I'd prefer to defer to the Security Team on this one, as to whether
>> > they'd generally accept it in packages they were releasing.
>>
>> Lintian complained that hardening-wrapper is deprecated so it had to
>> be replaced with this.
>>
> That's irrelevant for stable. We keep changes in stable to a minimum.
> You can go have fun and break stuff in unstable, not in stable.
We have a master branch where we have fun. This jessie branch keeps
changes to a minimum and does not break anything. When these changes
where done in early 2015 they were well reviewed and tested with the
target of getting into Jessie, which it unfortunately missed. This
change has been also in the master branch and thus in unstable and
testing for many months already without breaking anything.
> [...]
>> > + * Adding mysqld_multi.server_lsb-header.patch, provides LSB headers for
>> > + example initscript (Closes: #778762)
>> > + * Adding mysqld_multi_confd.patch, makes mysqld_multi reading conf.d
>> > + (Closes: #778761)
>> >
>> > This seems a little featureish. The only packages shipping files in the
>> > conf.d folder appear to be MySQL variants, so I guess this isn't too
>> > bad.
>>
>> Very few people run multiple different mysqld daemons on the same
>> system, and this thing must have been broken for a long time. Here
>> somebody scratched their own itch and fixed the buggy scripts
>> inherited from older packaging.
>>
>> These have been well reviewed and deemed safe changes. It would be a
>> shame not to release these fixes. There are very few contributors in
>> the MySQL packaging team and we should value the work of new people
>> who show up and provide ready-made patches.
>>
> Same as above.
>
> Cheers,
> Julien
Reply to: