Bug#786713: transition: libwps

[Rene Engelhard <rene@debian.org>]

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: transition

Hi,

libwps 0.4.0 changed API of one function (and thus also SONAME).

It is already in NEW since May 17.

Reverse dependencies (source):

# grep-dctrl -FDepends libwps -sSource /var/lib/apt/lists/http.debian.net_debian_dists_sid_main_binary-amd64_Packages | sort | uniq
Source: abiword (3.0.0-8)
Source: calligra (1:2.8.5+dfsg-1)
Source: libreoffice
Source: libwps
Source: writerperfect

- writerperfect 0.9.3 (in experimental) already was adapted for 0.4.0 and uses
  it. Will upload to sid together with libwps itself
- libreoffice
  - 5.0.0 beta1 requires it (5.0.0 final will be there end of July already)
  - the patch committed for 5.0.0 beta1[0] also applies to 4.3.3, should work.
    Will upload to sid together with libwps itself. It's a bit bigger because
    it also adds support for new file formats but if ththe full one doesn't work
    we can strip it down.
- abiword and calligra
  - don't have official patches/upstream work yet (they even didn't get the
    last transition done upstream...) but the change is easy and except the
    change of the .pc mainly a one-liner[1] for both. 
    I'd upload abiword myself (orphaned; QA upload, collab-maint..) and file
    a bug for calligra

Of course we should wait for it to be out of NEW first.
Ben file:

title = "libwps";
is_affected = .depends ~ "libwps-0.3-3" | .depends ~ "libwps-0.4-4";
is_good = .depends ~ "libwps-0.4-4";
is_bad = .depends ~ "libwps-0.3-3";

Regards,

Rene

[0]
http://cgit.freedesktop.org/libreoffice/core/tree/writerperfect/source/calc/MSWorksCalcImportFilter.cxx?id=f9568335a653f72732f9c8ebf007cf8850021ff9

[1]
+--- calligra-2.8.5+dfsg.orig/filters/words/works/import/WPSImport.cpp
++++ calligra-2.8.5+dfsg/filters/words/works/import/WPSImport.cpp
+@@ -43,7 +43,9 @@ private:
+     bool _isSupportedFormat(librevenge::RVNGInputStream *input, const char * /* password */)
+     {
+         libwps::WPSKind kind = libwps::WPS_TEXT;
+-        libwps::WPSConfidence confidence = libwps::WPSDocument::isFileFormatSupported(input, kind);
++        libwps::WPSCreator creator;
++        bool needsEncoding;
++        libwps::WPSConfidence confidence = libwps::WPSDocument::isFileFormatSupported(input, kind, creator, needsEncoding);
+         if ((libwps::WPS_TEXT != kind) || (confidence != libwps::WPS_CONFIDENCE_EXCELLENT))
+         {
+             fprintf(stderr, "ERROR: We have no confidence that you are giving us a valid Microsoft Works document.\n");

-- System Information:
Debian Release: 7.8
  APT prefers oldstable
  APT policy: (500, 'oldstable')
Architecture: armhf (armv7l)

Kernel: Linux 3.4.79-sun7i (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash