[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#785510: jessie-pu: package smstools/3.1.15-1.1



Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian.org@packages.debian.org
Usertags: pu

Hi,

I intend to upload smstools 3.1.15-1.1+deb8u1 to stable, fixing the
following bug:

#782996: smsd: 'reload' function of initscript broken if used by systemd

I uploaded the fixed package to unstable a few days before the release
of Jessie. Unfortunately it was to late for the package to still enter
stable in time. But back then, jchristau and mbiebl agreed on IRC at
#debian-release that this fix should be uploaded to proposed-updates later.

Cheers,
 jonas
diff -u smstools-3.1.15/debian/changelog smstools-3.1.15/debian/changelog
--- smstools-3.1.15/debian/changelog
+++ smstools-3.1.15/debian/changelog
@@ -1,3 +1,17 @@
+smstools (3.1.15-1.1+deb8u1) stable; urgency=high
+
+  * NMU by Jonas Meurer to push the fix into Jessie.
+  * Fix initscript (debian/init.d):
+    * drop action 'reload' as it does not what policy demands it to do. Use
+      'force-reload' in logrotate post-rotate action. This fixes 'force-reload'
+      action when used through systemd tools and prevents the smsd daemon
+      process from being killed at every log rotation. (closes: #782996)
+    * source /lib/lsb/init-functions in order to make systemd tools aware of
+      status changes to the daemon that have been caused by invoking the
+      initscript directly.
+
+ -- Jonas Meurer <mejo@debian.org>  Sun, 17 May 2015 12:05:33 +0200
+
 smstools (3.1.15-1.1) unstable; urgency=low
 
   * NMU - preventing smstools from entering jessie.
diff -u smstools-3.1.15/debian/init.d smstools-3.1.15/debian/init.d
--- smstools-3.1.15/debian/init.d
+++ smstools-3.1.15/debian/init.d
@@ -25,6 +25,8 @@
 
 test -x $DAEMON || exit 0
 
+. /lib/lsb/init-functions
+
 if [ ! -f /etc/default/$PACKAGE ]
 then
 	exit 1
@@ -218,17 +220,6 @@
 		echo "$NAME."
 
 	;;
-	reload)
-		echo -n "Reloading $DESC: "
-		status
-		if [ "$?" = 0 ]; then
-			stop restart
-			start
-		else
-			echo "$NAME is not running."
-		fi
-		
-	;;
 
 	restart|force-reload)
 		echo -n "Restarting $DESC: "
@@ -237,7 +228,7 @@
 	;;
 
 	*)
-		echo "Usage: /etc/init.d/$NAME {start|stop|force-stop|reload|force-reload|restart|status}"
+		echo "Usage: /etc/init.d/$NAME {start|stop|force-stop|force-reload|restart|status}"
 		exit 3
 	;;
 esac
diff -u smstools-3.1.15/debian/logrotate smstools-3.1.15/debian/logrotate
--- smstools-3.1.15/debian/logrotate
+++ smstools-3.1.15/debian/logrotate
@@ -5,5 +5,5 @@
     missingok
     postrotate
-        invoke-rc.d smstools reload > /dev/null
+        invoke-rc.d smstools force-reload > /dev/null
     endscript
 }

Reply to: