Bug#782310: unblock: gnome-font-viewer/3.14.0-2
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package gnome-font-viewer
it's a trivial fix for a segfault quite some users hit
diff -Nru gnome-font-viewer-3.14.0/debian/changelog gnome-font-viewer-3.14.0/debian/changelog
--- gnome-font-viewer-3.14.0/debian/changelog 2014-09-23 08:20:37.000000000 +0100
+++ gnome-font-viewer-3.14.0/debian/changelog 2015-04-10 10:28:46.000000000 +0100
@@ -1,3 +1,10 @@
+gnome-font-viewer (3.14.0-2) unstable; urgency=medium
+
+ * Cherry-pick an upstream patch to fix a crash when operating on certain
+ invalid files (Closes: #781229) (LP: #1436736)
+
+ -- Sebastien Bacher <seb128@ubuntu.com> Thu, 26 Mar 2015 09:54:17 +0100
+
gnome-font-viewer (3.14.0-1) unstable; urgency=medium
* New upstream release.
diff -Nru gnome-font-viewer-3.14.0/debian/patches/git_variable_init.patch gnome-font-viewer-3.14.0/debian/patches/git_variable_init.patch
--- gnome-font-viewer-3.14.0/debian/patches/git_variable_init.patch 1970-01-01 01:00:00.000000000 +0100
+++ gnome-font-viewer-3.14.0/debian/patches/git_variable_init.patch 2015-04-10 10:28:12.000000000 +0100
@@ -0,0 +1,28 @@
+From 9d4ec7300bbe57c2ebf36d292f6b574f27325fbc Mon Sep 17 00:00:00 2001
+From: Matthias Clasen <mclasen@redhat.com>
+Date: Thu, 13 Nov 2014 14:25:09 -0500
+Subject: Fix an uninitialized variable
+
+The str variable may be freed without ever having been set
+here, if we take one of the early gotos. This is showing up
+as a frequent crash in Fedoras retrace server:
+
+https://bugzilla.redhat.com/show_bug.cgi?id=1148522
+
+diff --git a/src/font-thumbnailer.c b/src/font-thumbnailer.c
+index 3e76323..57be150 100644
+--- a/src/font-thumbnailer.c
++++ b/src/font-thumbnailer.c
+@@ -181,7 +181,7 @@ main (int argc,
+ cairo_t *cr;
+ cairo_text_extents_t text_extents;
+ cairo_font_face_t *font;
+- gchar *str;
++ gchar *str = NULL;
+ gdouble scale, scale_x, scale_y;
+
+ const GOptionEntry options[] = {
+--
+cgit v0.10.2
+
+
diff -Nru gnome-font-viewer-3.14.0/debian/patches/series gnome-font-viewer-3.14.0/debian/patches/series
--- gnome-font-viewer-3.14.0/debian/patches/series 2012-03-12 23:14:22.000000000 +0000
+++ gnome-font-viewer-3.14.0/debian/patches/series 2015-04-10 10:28:59.000000000 +0100
@@ -0,0 +1 @@
+git_variable_init.patch
unblock gnome-font-viewer/3.14.0-2
-- System Information:
Debian Release: jessie/sid
APT prefers vivid
APT policy: (500, 'vivid'), (500, 'utopic-updates'), (500, 'utopic-security')
Architecture: i386 (i686)
Kernel: Linux 3.19.0-12-generic (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Reply to: