[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#781448: marked as done (unblock (pre-approval): libcap2/1:2.24-8)

Your message dated Mon, 30 Mar 2015 14:10:55 +0200
with message-id <55193D4F.1040008@thykier.net>
and subject line Re: Bug#781448: unblock (pre-approval): libcap2/1:2.24-8
has caused the Debian Bug report #781448,
regarding unblock (pre-approval): libcap2/1:2.24-8
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
781448: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=781448
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi,

in #780432 we had:

On 2015-03-13 22:13, Niels Thykier wrote:
> On 2015-03-13 21:44, Christian Kastner wrote:
>> Furthermore, would you perhaps be willing to also accept a fix for
>> #768229 (obsolete conffile removal)? If so, I'll provide an updated debdiff.
> 
> Ack, please go ahead.  Assuming the conffile removal is done by
> debhelper's maintscript file, please consider it pre-approved as well
> and include it.

Well, even though this changed passed all my local tests safely [1],
there are scenarios where this change leads to conffile breakage, see RC
bug #781050.

I researched this a bit and my impression is that there is yet no safe
and trivial way to remove a conffile from a package A (where is has
become obsolete) after it has been moved to another package B (but B
might not be installed). See [2] and [3], for example.

The attached debdiff drops debian/libcap2-bin.maintscript. This means
that #768229 will have to be reopened, but I'd rather accept this wart
than attempt any non-trivial solution this late in the freeze.

The debdiff also contains a trivial and obvious fix for debian/watch,
would that be OK?

Regards,
Christian

[1] https://bugs.debian.org/780411#44

[2] https://bugs.debian.org/595112

[3] https://lists.debian.org/debian-devel/2012/02/thrd2.html#00249

diff -Nru libcap2-2.24/debian/changelog libcap2-2.24/debian/changelog
--- libcap2-2.24/debian/changelog	2015-03-14 02:36:27.000000000 +0100
+++ libcap2-2.24/debian/changelog	2015-03-29 15:10:08.000000000 +0200
@@ -1,3 +1,13 @@
+libcap2 (1:2.24-8) unstable; urgency=medium
+
+  * debian/libcap2-bin.maintscript:
+    - Drop, because using rm_conffile to clean up an obsolete conffile that
+      was moved to another package can lead to breakage, see:  Closes: #781050
+  * debian/watch:
+    - Drop stray empty opts= (invalid syntax breaks uscan checks)
+
+ -- Christian Kastner <debian@kvr.at>  Sun, 29 Mar 2015 15:00:39 +0200
+
 libcap2 (1:2.24-7) unstable; urgency=medium
 
   * debian/libcap2-bin.maintscript:
diff -Nru libcap2-2.24/debian/libcap2-bin.maintscript libcap2-2.24/debian/libcap2-bin.maintscript
--- libcap2-2.24/debian/libcap2-bin.maintscript	2015-03-14 02:36:27.000000000 +0100
+++ libcap2-2.24/debian/libcap2-bin.maintscript	1970-01-01 01:00:00.000000000 +0100
@@ -1 +0,0 @@
-rm_conffile /etc/security/capability.conf 1:2.24-7~ libcap2-bin
diff -Nru libcap2-2.24/debian/watch libcap2-2.24/debian/watch
--- libcap2-2.24/debian/watch	2015-03-14 02:36:27.000000000 +0100
+++ libcap2-2.24/debian/watch	2015-03-29 15:10:08.000000000 +0200
@@ -4,5 +4,4 @@
 # uncompressed tarball, and uscan currently does not have a mechanism to
 # implement this
 
-opts=\
 https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/libcap-(.+).tar.xz

--- End Message ---
--- Begin Message --- 
On 2015-03-29 15:46, Niels Thykier wrote:
> Control: tags -1 confirmed moreinfo
> 
> [...]
> 
> Hi Christian,
> 
> Thanks for looking into it.
> 
> Indeed, I would also rather have  an obsolete conffile than ending up
> with the #781050 in a released Jessie.
> 
> Please go ahead with this solution - feel free to include the watch-file
> change as well.
> 
> Thanks,
> ~Niels
> 
> 


I saw it got uploaded and I have now unblocked it.

Thanks,
~Niels

--- End Message ---
Reply to: