--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package mate-settings-daemon
+ * debian/patches:
+ + Add README file explaining our patch naming scheme.
-> explains that 000x patches are upstream patches.
+ + Add 0002_fix-a11y-keyboard-dialog-segfaults.patch. Fix segfaults when
+ clicking on the checkboxes in the a11y-keybord configuration dialog.
+ (Closes: #779916).
-> Prevent a11y (keyboard) configuration dialog from crashing when clicking
into any of the provided checkboxes. For details on how to reproduce see
[1].
I could reproduce the observed issue with 1.8.2-1 of m-s-d and can
confirm that it is fixed with this upload.
As this is an a11y that was easy to fix I directly uploaded the package
(unfortunately with a typo in the changelog).
light+love
Mike
[1] https://github.com/mate-desktop/mate-settings-daemon/issues/70
unblock mate-settings-daemon/1.8.2-2
-- System Information:
Debian Release: 8.0
APT prefers stable
APT policy: (990, 'stable'), (500, 'testing-updates'), (500, 'testing-proposed-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
diff -Nru mate-settings-daemon-1.8.2/debian/changelog mate-settings-daemon-1.8.2/debian/changelog
--- mate-settings-daemon-1.8.2/debian/changelog 2014-10-24 11:33:23.000000000 +0200
+++ mate-settings-daemon-1.8.2/debian/changelog 2015-03-10 18:00:07.000000000 +0100
@@ -1,3 +1,14 @@
+mate-settings-daemon (1.8.2-2) unstable; urgency=medium
+
+ [ Mike Gabriel ]
+ * debian/patches:
+ + Add README file explaining our patch naming scheme.
+ + Add 0002_fix-a11y-keyboard-dialog-segfaults.patch. Fix segfaults when
+ clicking on the checkboxes in the a11y-keybord configuration dialog.
+ (Closes: #779916).
+
+ -- Mike Gabriel <sunweaver@debian.org> Tue, 10 Mar 2015 17:59:38 +0100
+
mate-settings-daemon (1.8.2-1) unstable; urgency=medium
[ Vangelis Mouhtsis ]
diff -Nru mate-settings-daemon-1.8.2/debian/patches/0002_fix-a11y-keyboard-dialog-segfaults.patch mate-settings-daemon-1.8.2/debian/patches/0002_fix-a11y-keyboard-dialog-segfaults.patch
--- mate-settings-daemon-1.8.2/debian/patches/0002_fix-a11y-keyboard-dialog-segfaults.patch 1970-01-01 01:00:00.000000000 +0100
+++ mate-settings-daemon-1.8.2/debian/patches/0002_fix-a11y-keyboard-dialog-segfaults.patch 2015-03-10 17:58:05.000000000 +0100
@@ -0,0 +1,96 @@
+From 025d64d20cd513c81dc88d369491f1fa555f352e Mon Sep 17 00:00:00 2001
+From: Monsta <monsta@inbox.ru>
+Date: Fri, 2 Jan 2015 18:18:27 +0300
+Subject: [PATCH] a11y-keyboard: fix crash
+
+fixes https://github.com/mate-desktop/mate-settings-daemon/issues/70
+---
+ plugins/a11y-keyboard/msd-a11y-preferences-dialog.c | 18 +++++++++---------
+ 1 file changed, 9 insertions(+), 9 deletions(-)
+
+diff --git a/plugins/a11y-keyboard/msd-a11y-preferences-dialog.c b/plugins/a11y-keyboard/msd-a11y-preferences-dialog.c
+index 72d42ff..675b993 100644
+--- a/plugins/a11y-keyboard/msd-a11y-preferences-dialog.c
++++ b/plugins/a11y-keyboard/msd-a11y-preferences-dialog.c
+@@ -458,7 +458,7 @@ on_sticky_keys_checkbutton_toggled (GtkToggleButton *button,
+
+ static void
+ on_bounce_keys_checkbutton_toggled (GtkToggleButton *button,
+- MsdA11yPreferencesDialog *dialog)
++ MsdA11yPreferencesDialog *dialog)
+ {
+ config_set_bounce_keys (dialog, gtk_toggle_button_get_active (button));
+ }
+@@ -649,7 +649,7 @@ setup_dialog (MsdA11yPreferencesDialog *dialog,
+ g_signal_connect (widget,
+ "toggled",
+ G_CALLBACK (on_sticky_keys_checkbutton_toggled),
+- NULL);
++ dialog);
+ enabled = config_get_sticky_keys (dialog, &is_writable);
+ ui_set_sticky_keys (dialog, enabled);
+ if (! is_writable) {
+@@ -662,7 +662,7 @@ setup_dialog (MsdA11yPreferencesDialog *dialog,
+ g_signal_connect (widget,
+ "toggled",
+ G_CALLBACK (on_bounce_keys_checkbutton_toggled),
+- NULL);
++ dialog);
+ enabled = config_get_bounce_keys (dialog, &is_writable);
+ ui_set_bounce_keys (dialog, enabled);
+ if (! is_writable) {
+@@ -675,7 +675,7 @@ setup_dialog (MsdA11yPreferencesDialog *dialog,
+ g_signal_connect (widget,
+ "toggled",
+ G_CALLBACK (on_slow_keys_checkbutton_toggled),
+- NULL);
++ dialog);
+ enabled = config_get_slow_keys (dialog, &is_writable);
+ ui_set_slow_keys (dialog, enabled);
+ if (! is_writable) {
+@@ -688,7 +688,7 @@ setup_dialog (MsdA11yPreferencesDialog *dialog,
+ g_signal_connect (widget,
+ "toggled",
+ G_CALLBACK (on_high_contrast_checkbutton_toggled),
+- NULL);
++ dialog);
+ enabled = config_get_high_contrast (dialog, &is_writable);
+ ui_set_high_contrast (dialog, enabled);
+ if (! is_writable) {
+@@ -701,7 +701,7 @@ setup_dialog (MsdA11yPreferencesDialog *dialog,
+ g_signal_connect (widget,
+ "toggled",
+ G_CALLBACK (on_at_screen_keyboard_checkbutton_toggled),
+- NULL);
++ dialog);
+ enabled = config_get_at_screen_keyboard (dialog, &is_writable);
+ ui_set_at_screen_keyboard (dialog, enabled);
+ if (! is_writable) {
+@@ -720,7 +720,7 @@ setup_dialog (MsdA11yPreferencesDialog *dialog,
+ g_signal_connect (widget,
+ "toggled",
+ G_CALLBACK (on_at_screen_reader_checkbutton_toggled),
+- NULL);
++ dialog);
+ enabled = config_get_at_screen_reader (dialog, &is_writable);
+ ui_set_at_screen_reader (dialog, enabled);
+ if (! is_writable) {
+@@ -739,7 +739,7 @@ setup_dialog (MsdA11yPreferencesDialog *dialog,
+ g_signal_connect (widget,
+ "toggled",
+ G_CALLBACK (on_at_screen_magnifier_checkbutton_toggled),
+- NULL);
++ dialog);
+ enabled = config_get_at_screen_magnifier (dialog, &is_writable);
+ ui_set_at_screen_magnifier (dialog, enabled);
+ if (! is_writable) {
+@@ -758,7 +758,7 @@ setup_dialog (MsdA11yPreferencesDialog *dialog,
+ g_signal_connect (widget,
+ "toggled",
+ G_CALLBACK (on_large_print_checkbutton_toggled),
+- NULL);
++ dialog);
+ enabled = config_get_large_print (&is_writable);
+ ui_set_large_print (dialog, enabled);
+ if (! is_writable) {
+
diff -Nru mate-settings-daemon-1.8.2/debian/patches/README mate-settings-daemon-1.8.2/debian/patches/README
--- mate-settings-daemon-1.8.2/debian/patches/README 1970-01-01 01:00:00.000000000 +0100
+++ mate-settings-daemon-1.8.2/debian/patches/README 2014-03-13 18:28:10.000000000 +0100
@@ -0,0 +1,3 @@
+0xxx: Grabbed from upstream development.
+1xxx: Possibly relevant for upstream adoption.
+2xxx: Only relevant for official Debian release.
diff -Nru mate-settings-daemon-1.8.2/debian/patches/series mate-settings-daemon-1.8.2/debian/patches/series
--- mate-settings-daemon-1.8.2/debian/patches/series 2014-10-23 13:26:50.000000000 +0200
+++ mate-settings-daemon-1.8.2/debian/patches/series 2015-03-10 17:58:15.000000000 +0100
@@ -1,2 +1,3 @@
0001_prefer-gcalculator-for-media-keys.patch
+0002_fix-a11y-keyboard-dialog-segfaults.patch
--- End Message ---