--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Please unblock package cvsweb
There is an incompatibility with Perl 5.18, which can be fixed by the patch
added in 3:3.0.6-8. The bug itself has been reported with severity important.
However the reporter speaks about "errors".
So given the fact, that the patch makes cvsweb fully functional again and is
pretty small, I'd like to request an unblock of the package.
The .debdiff is attached. It also covers the fact, that the package has been
moved to collab-maint.
Regards, Daniel
unblock cvsweb/3:3.0.6-8
- -- System Information:
Debian Release: 8.0
APT prefers unstable
APT policy: (850, 'unstable'), (700, 'testing'), (560, 'stable'), (500, 'oldstable'), (110, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJU44MvAAoJEEvNBWfCltBdHtAP/0LkjoItzVfo7sixb8lRIAQ9
wQeSBbFRJMZjKGRt3LPVkxZ9HMNhi/yrz6EQLyAR62yMUCWCTvpdKNf2R7gcG9LP
4me54mEq5TweQreEZ4qYVkEgUXW1uy0MlBYSydfy8/E4j/L4vbwWIahSIVtnoI48
h58bd1LP93ztOxkt/uoF83OUAc+rBSC1mQl2MA34CAv9MIW6VJirPZNbgwo9Kh81
tJFuu4D20W/1t8/OJ/gisnOXp7KGKhs87jBPaj6mj6PAr4/hPAaw+P6vvHjwvakP
WkzU5eSOz0OTmLr36bweTd+hdcRAcVqJ19Z0oz8jU2CgyKAyLajm65J0vmSAP4vB
s/eE6NZHzTmkoAXRUDU0meyLcxkkl1U21hSVWei44TulVzo0yXHixx56Feipl0B1
z4HQ5ZomYfd+fa3VhX7+GGchQZEQPq+/wzFWQEXzJPBp12Y2sDx/XaoJLPJymL2M
xte5ERfurb5UV7qXeg3bVXzN+Wq2udgPsutFkiGN6GcTvOCobQCoq846wPN0HyU/
bqc6Zx4eqggQ2zSJnq2f+ZfA4X+YFitHCtL/JjOsdKIHGeoUUAkWF3yh9fS8NisC
rkaaIzqOXBZaUp+CGJ58EdNNnAFqF9v8oXvJby71+A4RZQFMT+7i7WAHaCzIoRV7
BJWV5+QghjhWGkLNEZs7
=TkaI
-----END PGP SIGNATURE-----
diff -Nru cvsweb-3.0.6/debian/changelog cvsweb-3.0.6/debian/changelog
--- cvsweb-3.0.6/debian/changelog 2011-10-27 23:32:13.000000000 +0200
+++ cvsweb-3.0.6/debian/changelog 2015-02-17 18:56:43.000000000 +0100
@@ -1,3 +1,13 @@
+cvsweb (3:3.0.6-8) unstable; urgency=medium
+
+ * debian/control (Vcs-Browser, Vcs-Svn): Relocated to collab-maint.
+ (DM-Upload-Allowed): Obsolete and dropped.
+ * debian/patches/733054_perl_518.patch: Added (closes: #733054).
+ - Added Perl 5.18 compatibility and fixed errors.
+ * debian/patches/series: Adjusted.
+
+ -- Daniel Leidert <dleidert@debian.org> Tue, 17 Feb 2015 18:56:37 +0100
+
cvsweb (3:3.0.6-7) unstable; urgency=low
* debian/control: Added Vcs-Svn field.
diff -Nru cvsweb-3.0.6/debian/control cvsweb-3.0.6/debian/control
--- cvsweb-3.0.6/debian/control 2011-10-27 23:23:35.000000000 +0200
+++ cvsweb-3.0.6/debian/control 2014-11-17 13:41:40.000000000 +0100
@@ -1,13 +1,12 @@
Source: cvsweb
-Maintainer: Daniel Leidert (dale) <daniel.leidert@wgdd.de>
+Maintainer: Daniel Leidert <dleidert@debian.org>
Section: vcs
Priority: optional
Build-Depends: debhelper (>> 7.0.50~)
Standards-Version: 3.9.2
Homepage: http://www.freebsd.org/projects/cvsweb.html
-Vcs-Browser: https://svn.wgdd.de/svn/packages/cvsweb/trunk/
-Vcs-Svn: https://svn.wgdd.de/svn/packages/cvsweb/trunk/
-DM-Upload-Allowed: yes
+Vcs-Browser: http://anonscm.debian.org/viewvc/collab-maint/deb-maint/cvsweb/trunk/
+Vcs-Svn: svn://anonscm.debian.org/collab-maint/deb-maint/cvsweb/trunk/
Package: cvsweb
Architecture: all
diff -Nru cvsweb-3.0.6/debian/patches/733054_perl_518.patch cvsweb-3.0.6/debian/patches/733054_perl_518.patch
--- cvsweb-3.0.6/debian/patches/733054_perl_518.patch 1970-01-01 01:00:00.000000000 +0100
+++ cvsweb-3.0.6/debian/patches/733054_perl_518.patch 2015-02-17 12:16:26.000000000 +0100
@@ -0,0 +1,25 @@
+Origin: http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/www/cvsweb/patches/patch-cvsweb.cgi?rev=1.1.2.2&content-type=text/plain
+Acked-by: Daniel Leidert <dleidert@debian.org>
+Description: Add Perl 5.18 compatibility.
+Bug-Debian: https://bugs.debian.org/733054
+
+--- a/cvsweb.cgi
++++ b/cvsweb.cgi
+@@ -1192,7 +1192,7 @@
+ <legend>General options</legend>
+ <input type="hidden" name="copt" value="1" />
+ EOF
+- for my $v qw(hidecvsroot hidenonreadable) {
++ for my $v (qw(hidecvsroot hidenonreadable)) {
+ printf(qq{<input type="hidden" name="%s" value="%s" />\n},
+ $v, $input{$v} || 0);
+ }
+@@ -2951,7 +2951,7 @@
+ print "<br />\n";
+
+ print '<i>';
+- if (defined @mytz) {
++ if (@mytz) {
+ my ($est) = $mytz[(localtime($date{$_}))[8]];
+ print scalar localtime($date{$_}), " $est</i> (";
+ } else {
diff -Nru cvsweb-3.0.6/debian/patches/series cvsweb-3.0.6/debian/patches/series
--- cvsweb-3.0.6/debian/patches/series 2010-08-07 14:22:52.000000000 +0200
+++ cvsweb-3.0.6/debian/patches/series 2015-02-17 12:16:26.000000000 +0100
@@ -1,3 +1,4 @@
+733054_perl_518.patch
01_debianize_script_and_config.patch
02_allow_cgiless_execution.patch
10_483442_fix_perl_510_test_failure.patch
--- End Message ---
--- Begin Message ---
On Wed, Feb 18, 2015 at 02:40:56PM +0100, Daniel Leidert <daniel.leidert@wgdd.de> wrote:
> Am Dienstag, den 17.02.2015, 19:44 +0100 schrieb Mehdi Dogguy:
> > Le 2015-02-17 19:06, Daniel Leidert a écrit :
> > > There is an incompatibility with Perl 5.18, which can be fixed by the
> > > patch
> > > added in 3:3.0.6-8. The bug itself has been reported with severity
> > > important.
> > > However the reporter speaks about "errors".
>
> I can verify, that version 3:3.0.6-7 results in an 500er error of the
> server, so it doesn't work at all. Thus a higher severity is justified.
>
> > Is this relevant for Perl >=5.18, or 5.18 only? Did you test your
> > changes using
> > Perl 5.14 too? (so that it keeps working even after a partial upgrade).
>
> I tested with both Perl versions. The patch consists of two changes and
> I'll explain both below.
>
Thanks for the detailed explanation. I've unblocked the package.
Regards,
--
Mehdi
--- End Message ---