[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#778568: marked as done (pre-approval: node-findit2/2.2.3-2)

Your message dated Tue, 17 Feb 2015 00:34:10 +0100
with message-id <9ddeff43b4d008d4b8ae7e2dad5d57f5@dogguy.org>
and subject line Re: Bug#778576: unblock: node-tap/0.4.13-2
has caused the Debian Bug report #778568,
regarding pre-approval: node-findit2/2.2.3-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
778568: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778568
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package node-findit2

The package build-depends on node-tap, a buggy package. However, this
dependency is strictly optional and is only used to run upstream tests.
Further, there are many examples of Debian JavaScript packages which
have tests disabled.

diff -Nru node-findit2-2.2.3/debian/changelog node-findit2-2.2.3/debian/changelog
--- node-findit2-2.2.3/debian/changelog	2014-10-20 00:05:27.000000000 +0000
+++ node-findit2-2.2.3/debian/changelog	2015-02-16 19:25:16.000000000 +0000
@@ -1,3 +1,9 @@
+node-findit2 (2.2.3-2) unstable; urgency=medium
+
+  * remove build dependency on buggy dependency: node-tap
+
+ -- Andrew Kelley <superjoe30@gmail.com>  Mon, 16 Feb 2015 19:25:08 +0000
+
 node-findit2 (2.2.3-1) unstable; urgency=medium
 
   * Initial release (Closes: #765772)
diff -Nru node-findit2-2.2.3/debian/control node-findit2-2.2.3/debian/control
--- node-findit2-2.2.3/debian/control	2014-10-20 00:03:35.000000000 +0000
+++ node-findit2-2.2.3/debian/control	2015-02-16 19:23:44.000000000 +0000
@@ -6,7 +6,6 @@
 Build-Depends:
  debhelper (>= 8)
  , dh-buildinfo
- , node-tap
  , nodejs
 Standards-Version: 3.9.6
 Homepage: https://github.com/andrewrk/node-findit
diff -Nru node-findit2-2.2.3/debian/rules node-findit2-2.2.3/debian/rules
--- node-findit2-2.2.3/debian/rules	2014-10-20 00:03:21.000000000 +0000
+++ node-findit2-2.2.3/debian/rules	2015-02-16 19:24:00.000000000 +0000
@@ -9,8 +9,6 @@
 
 #override_dh_auto_build:
 
-override_dh_auto_test:
-	tap test/*.js
 
 

unblock node-findit2/2.2.3-1

-- System Information:
Debian Release: 8.0
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message --- 
Le 2015-02-17 00:07, Andrew Kelley a écrit :

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package node-tap

The bug that caused this package to be scheduled for autoremoval is
fixed with this small patch which disables a single test.



Unblocked.

Thanks for your work!

P.S.: This will also close 778568 as well.

Regards,

--
Mehdi

--- End Message ---
Reply to: