[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#777047: pu: vpim



On 04/02/15 14:58, Adam D. Barratt wrote:
> Control: tags -1 + moreinfo
>
> On 2015-02-04 13:02, Daniel Pocock wrote:
>> Package: release.debian.org
>> Tags: wheezy
>> User: release.debian.org@packages.debian.org
>> UserTags: unblock
>
> Nope, that would be "pu".

I already noticed that and fixed it with an email to control@
>
>> The package vpim in wheezy is broken, wheezy has Ruby 1.9 but the
>> package installs files for Ruby 1.8.  Here is the bug:
>>
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682772
>>
>> The package was fixed with an NMU for jessie, this should also be
>> uploaded to wheezy-proposed-updates
>>
>> Please confirm if I can upload the jessie version to
>> wheezy-proposed-updates
>
> Under other circumstances and given the nature of the changes and the
> package's maintenance history and popcon, I'd be more inclined to
> suggest removal instead tbh. (I follow -qa@, so I'm aware of why
> you're currently taking an interest in the package.)
>

I've had some communication with upstream and contributed some fixes to
his repository already[1] and I've helped him get it to build with
travis-ci[2] so it will be easier to get the project back on track.

I don't know a lot about Ruby and would defer to somebody more
experienced with that ecosystem and Ruby packaging to advise whether it
is better to work with the vpim code base or to start the process of
packaging some other iCalendar library for Ruby

For the immediate requirement (DMD) vpim appears sufficient, I attach a
sample of my testing



>> I've asked DSA to install it to ullmann.debian.org, please add it to
>> wheezy-updates if possible to make that easier.
>
> From previous interactions and some discussion on IRC I don't believe
> that's likely to be a requirement in practice. If it becomes an issue
> then we can re-visit it later.
>
>> Please let me know if I have written the changelog entry correctly or if
>> I need to change anything else.
>
> +vpim (0.695-1.1+deb7u1) wheezy-proposed-updates; urgency=medium
>
> The version number needs to be lower than the package in testing -
> convention would be 0.695-1.1~deb7u1. I'd also appreciate confirmation
> that the resulting package has been tested on wheezy.

I've fixed the version in the changelog and attach a revised debdiff

The attached test output was generated running dmd.cgi on a wheezy machine.

1. https://github.com/sam-github/vpim/commits/master

2. https://travis-ci.org/sam-github/vpim


$ ./dmd.cgi
(offline mode: enter name=value pairs on standard input)
email1=daniel@pocock.pro
format=ics
Content-type: text/calendar
Content-Disposition: attachment; filename="dmd.ics"

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Ensemble Independent//vPim 0.695//EN
CALSCALE:Gregorian
BEGIN:VTODO
SUMMARY:jabberd2: RC bug needs fixing: #742894: Incomplete debian/copyright
  [was: Uploading package(s)]
DESCRIPTION:jabberd2: RC bug needs fixing: #742894: Incomplete debian/copyr
 ight [was: Uploading package(s)]
URL:http://bugs.debian.org/742894
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:ck: Migration: Has been trying to migrate for 278 days
DESCRIPTION:ck: Migration: Has been trying to migrate for 278 days
URL:http://qa.debian.org/excuses.php?package=ck
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:jabberd2: Migration: Not in testing for 272 days
DESCRIPTION:jabberd2: Migration: Not in testing for 272 days
URL:http://qa.debian.org/excuses.php?package=jabberd2
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:qpid-tools: Migration: Not in testing for 227 days
DESCRIPTION:qpid-tools: Migration: Not in testing for 227 days
URL:http://qa.debian.org/excuses.php?package=qpid-tools
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:sipml5: Migration: Not in testing for 79 days
DESCRIPTION:sipml5: Migration: Not in testing for 79 days
URL:http://qa.debian.org/excuses.php?package=sipml5
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:syslog-nagios-bridge: Migration: Not in testing for 42 days
DESCRIPTION:syslog-nagios-bridge: Migration: Not in testing for 42 days
URL:http://qa.debian.org/excuses.php?package=syslog-nagios-bridge
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:qpid-proton: New version:  ready for upload
DESCRIPTION:qpid-proton: New version:  ready for upload
URL:http://git.debian.org/?p=pkg-middleware/qpid-proton.git
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:jabberd2: New version:  ready for upload
DESCRIPTION:jabberd2: New version:  ready for upload
URL:http://anonscm.debian.org/gitweb/?p=pkg-xmpp/jabberd2.git
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:jssip: New version available: 0.6.17
DESCRIPTION:jssip: New version available: 0.6.17
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:postbooks-schema-demo: New version available: 4.8.1
DESCRIPTION:postbooks-schema-demo: New version available: 4.8.1
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:simpleid: New version available: 0.9.1
DESCRIPTION:simpleid: New version available: 0.9.1
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:qpid-tools: New version available: 0.30
DESCRIPTION:qpid-tools: New version available: 0.30
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:ganglia: New version available: 3.7.0
DESCRIPTION:ganglia: New version available: 3.7.0
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:postbooks: New version available: 4.8.1
DESCRIPTION:postbooks: New version available: 4.8.1
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:resiprocate: New version available: 1.9.8
DESCRIPTION:resiprocate: New version available: 1.9.8
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:ganglia-web: New version available: 4.0.0
DESCRIPTION:ganglia-web: New version available: 4.0.0
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:tbdialout: New version available: 1.7.2pre1
DESCRIPTION:tbdialout: New version available: 1.7.2pre1
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:pegjs: New version available: 0.8.0
DESCRIPTION:pegjs: New version available: 0.8.0
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
BEGIN:VTODO
SUMMARY:drupal7-mod-libraries: New version available: 2.2
DESCRIPTION:drupal7-mod-libraries: New version available: 2.2
URL:
ORGANIZER:debian-qa@lists.debian.org
END:VTODO
END:VCALENDAR

diff -u vpim-0.695/debian/rules vpim-0.695/debian/rules
--- vpim-0.695/debian/rules
+++ vpim-0.695/debian/rules
@@ -28,12 +28,13 @@
 installdoc = install -g root -o root -m 644
 
 build:
-	ruby setup.rb config --installdirs=std
-	ruby setup.rb setup
+	dh_ruby --setuprb --build
 	touch stamp-build
 
 clean: debclean
+	dh_ruby --setuprb --clean
 	ruby setup.rb distclean
+	rm -f debian/vpim.substvars
 	rm -f stamp-build
 
 debclean:
@@ -44,6 +45,9 @@
 binary-arch:
 # Nothing to be done here
 
+export DH_RUBY_IGNORE_TESTS=require-rubygems
+export DH_RUBY_USE_DH_AUTO_INSTALL_DESTDIR=yes
+
 binary-indep: debclean
 	test -f stamp-build || $(MAKE) -f debian/rules build
 	$(installbin) -d debian/tmp/DEBIAN
@@ -56,7 +60,7 @@
 	$(installdoc) debian/copyright debian/tmp/usr/share/doc/$(package)/
 	$(installdoc) debian/README.Debian debian/tmp/usr/share/doc/$(package)/
 	#
-	ruby setup.rb install --prefix=debian/tmp
+	dh_ruby --setuprb --install debian/tmp
 	$(installdoc) CHANGES debian/tmp/usr/share/doc/$(package)/changelog
 	$(installdoc) samples/README.mutt debian/tmp/usr/share/doc/$(package)/
 	$(installdoc) README debian/tmp/usr/share/doc/$(package)/
diff -u vpim-0.695/debian/control vpim-0.695/debian/control
--- vpim-0.695/debian/control
+++ vpim-0.695/debian/control
@@ -2,14 +2,15 @@
 Section: libs
 Priority: optional
 Maintainer: Joey Schulze <joey@debian.org>
-Build-Depends: ruby, ruby1.8
+Build-Depends: gem2deb
 Standards-Version: 3.8.0
+XS-Ruby-Versions: all
 
 Package: vpim
 Architecture: all
 Section: libs
 Priority: optional
-Depends: ruby, ruby1.8
+Depends: ruby
 Suggests: facter
 Description: Ruby support for vCard and iCalendar
  This package provides calendaring, scheduling, and contact support
diff -u vpim-0.695/debian/changelog vpim-0.695/debian/changelog
--- vpim-0.695/debian/changelog
+++ vpim-0.695/debian/changelog
@@ -1,3 +1,22 @@
+vpim (0.695-1.1~deb7u1) wheezy-proposed-updates; urgency=medium
+
+  * Non-maintainer upload.
+  * Backport the fix uploaded to jessie for #682772
+
+ -- Daniel Pocock <daniel@pocock.pro>  Tue, 03 Feb 2015 20:37:43 +0100
+
+vpim (0.695-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Port to Ruby 1.9+ (Closes: #682772)
+    - debian/control: change Build-Depends to gem2deb; drop dependency on
+      ruby1.8
+    - debian/rules: change build to call `dh_ruby --setuprb` instead of
+      manually calling `ruby setup.rb`. This will make sure the package will
+      install code that is available for all Ruby interpreters.
+
+ -- Antonio Terceiro <terceiro@debian.org>  Wed, 15 Jan 2014 13:30:44 +0100
+
 vpim (0.695-1) unstable; urgency=low
 
   * New upstream release

Reply to: