[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#776008: marked as done (unblock: needrestart/1.2-7)



Your message dated Thu, 29 Jan 2015 19:18:14 +0100
with message-id <54CA7966.4020909@thykier.net>
and subject line Re: Bug#776008: unblock: needrestart/1.2-7
has caused the Debian Bug report #776008,
regarding unblock: needrestart/1.2-7
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
776008: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776008
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package needrestart

It fixes:

   * Add missing second patch 15-fix-progressbar-non-interactive to fix #768124.
     The patch was not completely added with 1.2-3.
     Closes: #768124


--- 1.2-6/debian/changelog      2014-12-04 14:15:54.812814981 +0100
+++ 1.2-7/debian/changelog      2014-12-18 21:53:53.165140592 +0100
@@ -1,3 +1,11 @@
+needrestart (1.2-7) unstable; urgency=low
+
+  * Add missing second patch 15-fix-progressbar-non-interactive to fix #768124.
+    The patch was not completely added with 1.2-3.
+    Closes: #768124
+
+ -- Patrick Matthäi <pmatthaei@debian.org>  Thu, 18 Dec 2014 21:44:56 +0100
+
 needrestart (1.2-6) unstable; urgency=high
 
   * Add patch 10-respect-override-auto to not restart services with overrides
diff -Naur '--exclude=.svn' 1.2-6/debian/patches/15-fix-progressbar-non-interactive.diff 1.2-7/debian/patches/15-fix-progressbar-non-interactive.diff
--- 1.2-6/debian/patches/15-fix-progressbar-non-interactive.diff        1970-01-01 01:00:00.000000000 +0100
+++ 1.2-7/debian/patches/15-fix-progressbar-non-interactive.diff        2014-12-18 21:53:53.169140561 +0100
@@ -0,0 +1,18 @@
+# Disable progress bar while running non-interactive.
+# Closes: #768124
+
+diff --git a/perl/lib/NeedRestart/UI.pm b/perl/lib/NeedRestart/UI.pm
+index 2441755..55f170e 100644                                                                                                                                                                                                               
+--- a/perl/lib/NeedRestart/UI.pm                                                                                                                                                                                                            
++++ b/perl/lib/NeedRestart/UI.pm                                                                                                                                                                                                            
+@@ -42,7 +42,7 @@ sub progress_prep($$$) {                                                                                                                                                                                                  
+     my $self = shift;                                                                                                                                                                                                                      
+     my ($max, $out) = @_;                                                                                                                                                                                                                  
+                                                                                                                                                                                                                                            
+-    unless($self->{debug}) {                                                                                                                                                                                                               
++    unless($self->{debug} || !exists($ENV{COLUMNS}) || !exists($ENV{LINES})) {                                                                                                                                                             
+       # restore terminal if required (debconf)                                                                                                                                                                                             
+       unless(-t *STDIN) {                                                                                                                                                                                                                  
+           open($self->{fhin}, '<&', \*STDIN) || die "Can't dup stdin: $!\n";                                                                                                                                                               
+--                                                                                                                                                                                                                                          
+2.1.3                                                                                                                                                                                                                                       
diff -Naur '--exclude=.svn' 1.2-6/debian/patches/series 1.2-7/debian/patches/series                                                                                                                                                          
--- 1.2-6/debian/patches/series 2014-12-04 14:15:54.892814609 +0100                                                                                                                                                                          
+++ 1.2-7/debian/patches/series 2014-12-18 21:53:53.169140561 +0100                                                                                                                                                                          
@@ -12,3 +12,4 @@                                                                                                                                                                                                                            
 12-ignore-systemd-user-sessions.diff                                                                                                                                                                                                        
 13-falsepos-aio-fix.diff                                                                                                                                                                                                                    
 14-wpa_supplicant-override.diff                                                                                                                                                                                                             
+15-fix-progressbar-non-interactive.diff


unblock needrestart/1.2-7

-- System Information:
Debian Release: 7.8
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

--- End Message ---
--- Begin Message ---
On 2015-01-22 17:50, Patrick Matthäi wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package needrestart
> 
> It fixes:
> 
>    * Add missing second patch 15-fix-progressbar-non-interactive to fix #768124.
>      The patch was not completely added with 1.2-3.
>      Closes: #768124
> 
> 
> [...]
> 

Unblocked, if only because "Use of uninitialized value ..." warnings
strain my eyes...

Anyhow, thanks for fixing this,
~Niels

--- End Message ---

Reply to: