--- Begin Message ---
Package: release.debian.org
Severity: normal
Tags: patch
User: release.debian.org@packages.debian.org
Usertags: unblock
fs-uae has a bug which results in segmentation faults when using
newer versions of the proprietary nVidia driver [1,2]. Initially,
this was blamed on the nVidia driver but it turned out to be a
bug in fs-uae after nVidia investigated the problem [3].
The actual patch to fix the issue just removes an fs-uae-internal
implementation of the glibc function mprotect() which is the
only change in fs-uae_2.4.1+ds-3.
Since this issue affects multiple users and many of them have
directly complained to me in form of bug reports, I would kindly
ask the release team to unblock fs-uae_2.4.1+ds-3 for Jessie.
I have already uploaded fs-uae_2.4.1+ds-3 to unstable and should
pop up on the buildds quickly. I am attaching its debdiff.
Cheers,
Adrian
unblock fs-uae/2.4.1+ds-3
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757164
> [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767109
> [3] http://fs-uae.net/2015/01/27/fs-uae-2-4-3-released
diff -Nru fs-uae-2.4.1+ds/debian/changelog fs-uae-2.4.1+ds/debian/changelog
--- fs-uae-2.4.1+ds/debian/changelog 2014-05-03 19:22:05.000000000 +0200
+++ fs-uae-2.4.1+ds/debian/changelog 2015-01-27 23:19:17.000000000 +0100
@@ -1,3 +1,11 @@
+fs-uae (2.4.1+ds-3) unstable; urgency=medium
+
+ * Add debian/patches/0003-remove-custom-mprotect-function.patch
+ to fix a segmentation fault when running fs-uae with recent
+ versions of the proprietary nVidia driver (Closes: #757164).
+
+ -- John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Tue, 27 Jan 2015 22:38:53 +0100
+
fs-uae (2.4.1+ds-2) unstable; urgency=medium
* Add missing dependency on python-pil for fs-uae-arcade in debian/control.
diff -Nru fs-uae-2.4.1+ds/debian/patches/0003-remove-custom-mprotect-function.patch fs-uae-2.4.1+ds/debian/patches/0003-remove-custom-mprotect-function.patch
--- fs-uae-2.4.1+ds/debian/patches/0003-remove-custom-mprotect-function.patch 1970-01-01 01:00:00.000000000 +0100
+++ fs-uae-2.4.1+ds/debian/patches/0003-remove-custom-mprotect-function.patch 2015-01-27 23:09:40.000000000 +0100
@@ -0,0 +1,26 @@
+Description: 0003-remove-custom-mprotect-function.patch
+ This patch removes an fs-uae-internal implementation of the glibc function
+ mprotect(). This implementation causes fa-uae to segfault when using
+ recent versions of the proprietary nVidia driver. nVidia has investigated
+ into the issue and identified the problem. Simply removing mprotect()
+ from the fs-uae code base results in the code using glibc's implementation
+ of mprotect() and fixes the segfault.
+
+--- fs-uae-2.4.1+ds.orig/src/od-fs/mman.cpp
++++ fs-uae-2.4.1+ds/src/od-fs/mman.cpp
+@@ -881,15 +881,6 @@ STATIC_INLINE uae_key_t find_shmkey (uae
+ return result;
+ }
+
+-int mprotect (void *addr, size_t len, int prot)
+-#ifdef PANDORA
+- __THROW
+-#endif
+-{
+- int result = 0;
+- return result;
+-}
+-
+ void *uae_shmat (int shmid, void *shmaddr, int shmflg)
+ {
+ write_log("uae_shmat shmid %d shmaddr %p, shmflg %d natmem_offset = %p\n",
diff -Nru fs-uae-2.4.1+ds/debian/patches/series fs-uae-2.4.1+ds/debian/patches/series
--- fs-uae-2.4.1+ds/debian/patches/series 2014-04-06 21:24:15.000000000 +0200
+++ fs-uae-2.4.1+ds/debian/patches/series 2015-01-27 23:05:45.000000000 +0100
@@ -1,2 +1,3 @@
0001-use-external-libglee.patch
0002-dont-copy-upstream-copying-file.patch
+0003-remove-custom-mprotect-function.patch
--- End Message ---
--- Begin Message ---
On 2015-01-27 23:35, John Paul Adrian Glaubitz wrote:
> Package: release.debian.org
> Severity: normal
> Tags: patch
> User: release.debian.org@packages.debian.org
> Usertags: unblock
>
> fs-uae has a bug which results in segmentation faults when using
> newer versions of the proprietary nVidia driver [1,2]. Initially,
> this was blamed on the nVidia driver but it turned out to be a
> bug in fs-uae after nVidia investigated the problem [3].
>
> The actual patch to fix the issue just removes an fs-uae-internal
> implementation of the glibc function mprotect() which is the
> only change in fs-uae_2.4.1+ds-3.
>
> Since this issue affects multiple users and many of them have
> directly complained to me in form of bug reports, I would kindly
> ask the release team to unblock fs-uae_2.4.1+ds-3 for Jessie.
>
> I have already uploaded fs-uae_2.4.1+ds-3 to unstable and should
> pop up on the buildds quickly. I am attaching its debdiff.
>
> Cheers,
> Adrian
>
> unblock fs-uae/2.4.1+ds-3
>
>> [...]
Unblocked, thanks.
~Niels
--- End Message ---