Bug#776393: unblock: tomcat-maven-plugin/1.1-2.2

[Niels Thykier <niels@thykier.net>]

Control: tags -1 moreinfo

On 2015-01-27 16:57, Emmanuel Bourg wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package tomcat-maven-plugin, the version 1.1-2.2 fixes
> the RC bug #686877, which completes the transition to Tomcat 7.
> 
> Thank you
> 
> unblock tomcat-maven-plugin/1.1-2.2
> 

Hi,

Thanks for working on this.  I just need one thing confirmed before I
unblock it.

> 
> [...]
> +-                container = new Catalina();
> +-                container.setCatalinaHome( configurationDir.getAbsolutePath() );
> ++                Catalina container = new Catalina();
> +                 ( (Catalina) container ).setConfigFile( serverXml.getPath() );
> +                 container.start();

Is this nameshadowing intended?  Based on the old code, there must be a
"<Type> container" definition elsewhere.  If this is a field, then this
would keep the field at its current value (I am guessing "null").

If this is indeed "as intended", then that is fine.  Just wanted to be sure.

Thanks,
~Niels