On 01/26/2015 07:54 PM, Michael Biebl wrote: >> unblock open-iscsi/2.0.873+git0.3b4b4500-4 > That patch doesn't look right. > > Calling systemctl from an init script is a big no-go. > > Second, shipping a generated unit file which does run /etc/init.d/foo is > a hack at best. > > I'd be really unhappy, if this was accepted. > Well, this is just an interim fix, for Jessie. For sid and later, we'll also ship the systemd files that'll be independent. That's something which'll require co-ordination with systemd team, and some testing once we have that support. > A few questions: > - If open-iscsi is supposed to provide remote file systems, how can it > have # Required-Start: $remote_fs > I don't have all the history, but I believe you could have your root fs being served off of an NFS root file system, while providing data LUNs over iSCSI. > That's a classic circular dep and most likely the reason for the issue > > - Why is umountiscsi.sh in a separate init script, when the open-iscsi > init script calls it via invoke-rc.d on stop? Again, I don't recollect every detail. But the open-iscsi script deals with the userspace daemon. Where as the umountiscsi.sh script is only used to deal with the iSCSI block devices mount/umount. It also takes care of LVM devices, if any, created on top of it. The iscsid daemon is not needed for the full operation of the iSCSI service. Hence the daemon handling is separated from the iSCSI sessions that are handled in-kernel. -- Ritesh Raj Sarraf | http://people.debian.org/~rrs Debian - The Universal Operating System
Attachment:
signature.asc
Description: OpenPGP digital signature