Bug#775752: unblock: frogr/0.10-2
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package frogr
It contains a fix for this bug:
https://bugzilla.gnome.org/show_bug.cgi?id=732475
This initializes the gcrypt library, otherwise frogr may experience
random crashes in some scenarios. This patch is already available in
the latest stable version of Frogr, and upstream strongly recommends
backporting it to this release.
unblock frogr/0.10-2
-- System Information:
Debian Release: 8.0
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru frogr-0.10/debian/changelog frogr-0.10/debian/changelog
--- frogr-0.10/debian/changelog 2014-06-17 10:47:52.000000000 +0300
+++ frogr-0.10/debian/changelog 2015-01-19 15:50:01.000000000 +0200
@@ -1,3 +1,10 @@
+frogr (0.10-2) unstable; urgency=medium
+
+ * fix-gcrypt-crash.patch:
+ - Fix crash in gcrypt.
+
+ -- Alberto Garcia <berto@igalia.com> Mon, 19 Jan 2015 15:45:16 +0200
+
frogr (0.10-1) unstable; urgency=medium
* New upstream release.
diff -Nru frogr-0.10/debian/patches/fix-gcrypt-crash.patch frogr-0.10/debian/patches/fix-gcrypt-crash.patch
--- frogr-0.10/debian/patches/fix-gcrypt-crash.patch 1970-01-01 02:00:00.000000000 +0200
+++ frogr-0.10/debian/patches/fix-gcrypt-crash.patch 2015-01-19 15:50:01.000000000 +0200
@@ -0,0 +1,42 @@
+From: Mario Sanchez Prada <msanchez@gnome.org>
+Subject: Fix initialization of gcrypt to avoid crashes
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=732475
+Origin: https://git.gnome.org/browse/frogr/commit/?id=d7f4e944aa691244e57a8fcc8f4f0e5f91da8686
+Index: frogr/src/flicksoup/fsp-session.c
+===================================================================
+--- frogr.orig/src/flicksoup/fsp-session.c
++++ frogr/src/flicksoup/fsp-session.c
+@@ -26,11 +26,16 @@
+ #include "fsp-session.h"
+
+ #include <config.h>
++#include <errno.h>
+ #include <gcrypt.h>
+ #include <libsoup/soup.h>
++#include <pthread.h>
+ #include <stdarg.h>
+ #include <string.h>
+
++/* We need this macro defined to properly initialize gcrypt */
++GCRY_THREAD_OPTION_PTHREAD_IMPL;
++
+ #define FLICKR_API_BASE_URL "https://api.flickr.com/services/rest";
+ #define FLICKR_API_UPLOAD_URL "https://up.flickr.com/services/upload";
+ #define FLICKR_REQUEST_TOKEN_OAUTH_URL "https://www.flickr.com/services/oauth/request_token";
+@@ -492,6 +497,16 @@ fsp_session_init
+ self->priv->using_default_proxy = TRUE;
+ self->priv->proxy_uri = NULL;
+
++ /* Apparently, we need to initialize gcrypt not to get a crash:
++ http://lists.gnupg.org/pipermail/gcrypt-devel/2003-August/000458.html */
++ if (!gcry_control (GCRYCTL_ANY_INITIALIZATION_P))
++ {
++ gcry_control (GCRYCTL_SET_THREAD_CBS, &gcry_threads_pthread);
++ gcry_check_version (NULL);
++ gcry_control (GCRYCTL_INIT_SECMEM, 32768);
++ gcry_control (GCRYCTL_INITIALIZATION_FINISHED);
++ }
++
+ #ifdef SOUP_VERSION_2_42
+ /* soup_session_async_new() deprecated in lisoup 2.42 */
+ self->priv->soup_session = soup_session_new ();
diff -Nru frogr-0.10/debian/patches/series frogr-0.10/debian/patches/series
--- frogr-0.10/debian/patches/series 1970-01-01 02:00:00.000000000 +0200
+++ frogr-0.10/debian/patches/series 2015-01-19 15:50:01.000000000 +0200
@@ -0,0 +1 @@
+fix-gcrypt-crash.patch
Reply to: