[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#775280: unblock: designate/2014.1-18



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear release team,

Here's the changes:

*/ Package is rebuilt against openstack-pkg-tools >= 22~ to fix the 
last systemd issue that was preventing startup of daemons on the first
install (see unblock bug #775278).

*/ To make sure the database directive is left unchanged unless the
user explicitely asked for automated management, and for consistency
across all OpenStack packages, the designate/configure_db debconf
directive default value is now set to false.

*/ For consistency with other OpenStack packages and to allow a better
compatibility with official puppet scripts, the postinst doesn't touch
the db connection directive and doesn't do the "designate-manage
database-init" and "designate-manage database-sync" unless explicitely
requested by the user through debconf. The pkgos_dbc_postinst isn't
called either if no db management is requested.

*/ For some reason, the database initialization was depending on the
dbc_upgrade variable, which is wrong: we really want the database to
be initialized at install time if designate/configure_db is true. This
upload corrects that too.

Please unblock designate/2014.1-18. Debdiff attached.

Cheers,

Thomas Goirand (zigo)

P.S: Please note that I only generate debdiff for the changes which
haven't been agreed on previously.               
diff -Nru designate-2014.1/debian/changelog designate-2014.1/debian/changelog
--- designate-2014.1/debian/changelog	2015-01-05 22:07:05.000000000 +0000
+++ designate-2014.1/debian/changelog	2015-01-09 00:17:00.000000000 +0000
@@ -1,3 +1,17 @@
+designate (2014.1-18) unstable; urgency=medium
+
+  * Removed dbc_upgrade = true check before db sync.
+
+ -- Thomas Goirand <zigo@debian.org>  Fri, 09 Jan 2015 00:16:40 +0000
+
+designate (2014.1-17) unstable; urgency=medium
+
+  * Rebuilt with openstack-pkg-tools (>= 22~): starts daemons on first install.
+  * designate/configure_db default value is now false.
+  * Do not call pkgos_dbc_postinst if designate/configure_db is false.
+
+ -- Thomas Goirand <zigo@debian.org>  Thu, 08 Jan 2015 15:49:46 +0000
+
 designate (2014.1-16) unstable; urgency=medium
 
   * Fixed homepage: stackforge -> openstack.
diff -Nru designate-2014.1/debian/control designate-2014.1/debian/control
--- designate-2014.1/debian/control	2015-01-05 22:07:05.000000000 +0000
+++ designate-2014.1/debian/control	2015-01-09 00:17:00.000000000 +0000
@@ -7,7 +7,7 @@
            Mehdi Abaakouk <sileht@sileht.net>
 Build-Depends: debhelper (>= 9),
                dh-systemd,
-               openstack-pkg-tools (>= 21~),
+               openstack-pkg-tools (>= 22~),
                python-all (>= 2.6.6-3~),
                python-pbr (>=0.6),
                python-setuptools,
diff -Nru designate-2014.1/debian/designate-common.postinst.in designate-2014.1/debian/designate-common.postinst.in
--- designate-2014.1/debian/designate-common.postinst.in	2015-01-05 22:07:05.000000000 +0000
+++ designate-2014.1/debian/designate-common.postinst.in	2015-01-09 00:17:00.000000000 +0000
@@ -13,12 +13,15 @@
 	pkgos_var_user_group designate
 	pkgos_write_new_conf designate designate.conf
 
-	pkgos_dbc_postinst ${CONF} storage:sqlalchemy database_connection designate $@
+	db_get designate/configure_db
+	if [ "$RET" = "true" ] ; then
+		pkgos_dbc_postinst ${CONF} storage:sqlalchemy database_connection designate $@
+	fi
 	pkgos_rabbit_write_conf ${CONF} DEFAULT designate
 	pkgos_write_admin_creds ${CONF} keystone_authtoken designate
 
 	db_get designate/configure_db
-	if [ "$RET" = "true" ] && [ "$dbc_upgrade" = "true" ] ; then
+	if [ "$RET" = "true" ] ; then
 		echo "Now doing designate-manage database-sync: this may take a while..."
 		su -s /bin/sh -c 'cd /tmp && designate-manage database-init' designate || true
 		su -s /bin/sh -c 'cd /tmp && designate-manage database-sync' designate
diff -Nru designate-2014.1/debian/designate-common.templates designate-2014.1/debian/designate-common.templates
--- designate-2014.1/debian/designate-common.templates	2015-01-05 22:07:05.000000000 +0000
+++ designate-2014.1/debian/designate-common.templates	2015-01-09 00:17:00.000000000 +0000
@@ -9,7 +9,7 @@
 
 Template: designate/configure_db
 Type: boolean
-Default: true
+Default: false
 _Description: Set up a database for Designate?
  No database has been set up for designate to use. Before continuing, you
  should make sure you have the following information:

Reply to: