[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#775278: unblock: openstack-pkg-tools/22



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear release team,

I'm sorry that I asked for a previous unblock of version 21 and had
to upload version 22, but another issue was found. Indeed, dh_installinit
must be called *after* dh_systemd_enable, otherwise the generated script
in the postinst is wrong, and the systemd unit is unmasked after
invoke-rc.d is called, resulting in the daemon not being started at the
install time (it is however started on next boot).

This is the only change in this version 22: dh_installinit is pushed
later on in the debian/rules include file.

I have rebuilt all OpenStack packages, however, only Nova and Ceilometer
are unchanged, so I'll open separate bugs for the other packages.

Note that I have run a full install test will all OpenStack packages, and
they installed without any issue (after a few more fixes), and I believe
that Andreas Beckman is running piuparts on all new upload to SID these
days. So this should hopefully be the last unblock serries for OpenStack.

Please unblock packages:
- openstack-pkg-tools/22
- nova/2014.1.3-9
- ceilometer/2014.1.3-6

Debdiffs attached.

Cheers,

Thomas Goirand (zigo)
diff -Nru nova-2014.1.3/debian/changelog nova-2014.1.3/debian/changelog
--- nova-2014.1.3/debian/changelog	2015-01-06 22:09:56.000000000 +0000
+++ nova-2014.1.3/debian/changelog	2015-01-08 16:07:07.000000000 +0000
@@ -1,3 +1,9 @@
+nova (2014.1.3-9) unstable; urgency=medium
+
+  * Rebuilt with openstack-pkg-tools (>= 22~): starts daemons on first install.
+
+ -- Thomas Goirand <zigo@debian.org>  Thu, 08 Jan 2015 16:06:43 +0000
+
 nova (2014.1.3-8) unstable; urgency=medium
 
   * Rebuilt with openstack-pkg-tools (>= 21~).
diff -Nru nova-2014.1.3/debian/control nova-2014.1.3/debian/control
--- nova-2014.1.3/debian/control	2015-01-06 22:09:56.000000000 +0000
+++ nova-2014.1.3/debian/control	2015-01-08 16:07:07.000000000 +0000
@@ -9,7 +9,7 @@
            gustavo panizzo <gfa@zumbi.com.ar>
 Build-Depends: debhelper (>= 9),
                dh-systemd,
-               openstack-pkg-tools (>= 21~),
+               openstack-pkg-tools (>= 22~),
                po-debconf,
                python-all (>= 2.6.6-3~),
                python-pbr (>= 0.6),
diff -Nru openstack-pkg-tools-21/debian/changelog openstack-pkg-tools-22/debian/changelog
--- openstack-pkg-tools-21/debian/changelog	2015-01-05 15:48:09.000000000 +0000
+++ openstack-pkg-tools-22/debian/changelog	2015-01-08 15:13:03.000000000 +0000
@@ -1,3 +1,10 @@
+openstack-pkg-tools (22) unstable; urgency=medium
+
+  * Calls dh_installinit after dh_systemd_enable so that systemd services are
+    started at install time.
+
+ -- Thomas Goirand <zigo@debian.org>  Thu, 08 Jan 2015 15:12:13 +0000
+
 openstack-pkg-tools (21) unstable; urgency=medium
 
   * Fixed mix-up with SYSTEM_USER and SYSTEM_GROUP in pkgos-gen-upstart-job.
diff -Nru openstack-pkg-tools-21/pkgos.make openstack-pkg-tools-22/pkgos.make
--- openstack-pkg-tools-21/pkgos.make	2015-01-05 15:48:09.000000000 +0000
+++ openstack-pkg-tools-22/pkgos.make	2015-01-08 15:13:03.000000000 +0000
@@ -34,7 +34,6 @@
 			pkgos-gen-upstart-job $$i ; \
 		fi \
 	done
-	dh_installinit --error-handler=true
 	# Generate the systemd unit file
 	# Note: because dh_systemd_enable is called by the
 	# dh sequencer *before* dh_installinit, we have
@@ -45,6 +44,7 @@
 		MYSERVICE=`echo $$MYSERVICE | sed 's/.init.in/.service/'` ; \
 		dh_systemd_enable $$MYSERVICE ; \
 	done
+	dh_installinit --error-handler=true
 
 gen-author-list:
 	git log --format='%aN <%aE>' | awk '{arr[$$0]++} END{for (i in arr){print arr[i], i;}}' | sort -rn | cut -d' ' -f2-
diff -Nru ceilometer-2014.1.3/debian/changelog ceilometer-2014.1.3/debian/changelog
--- ceilometer-2014.1.3/debian/changelog	2015-01-05 16:11:50.000000000 +0000
+++ ceilometer-2014.1.3/debian/changelog	2015-01-08 15:44:08.000000000 +0000
@@ -1,3 +1,9 @@
+ceilometer (2014.1.3-6) unstable; urgency=medium
+
+  * Rebuilt with openstack-pkg-tools (>= 22~): starts daemons on first install.
+
+ -- Thomas Goirand <zigo@debian.org>  Thu, 08 Jan 2015 15:37:34 +0000
+
 ceilometer (2014.1.3-5) unstable; urgency=medium
 
   * Now depends on openstack-pkg-tools (>= 21~).
diff -Nru ceilometer-2014.1.3/debian/control ceilometer-2014.1.3/debian/control
--- ceilometer-2014.1.3/debian/control	2015-01-05 16:11:50.000000000 +0000
+++ ceilometer-2014.1.3/debian/control	2015-01-08 15:44:08.000000000 +0000
@@ -7,7 +7,7 @@
            Mehdi Abaakouk <sileht@sileht.net>
 Build-Depends: debhelper (>= 9),
                dh-systemd,
-               openstack-pkg-tools (>= 21~),
+               openstack-pkg-tools (>= 22~),
                po-debconf,
                python-all (>= 2.6.6-3~),
                python-pbr (>= 0.6),

Reply to: