[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#774635: unblock: openstack-pkg-tools/21



On 01/06/2015 12:18 AM, Ivo De Decker wrote:
> Control: tags -1 moreinfo
> 
> Hi,
> 
> On Mon, Jan 05, 2015 at 04:54:09PM +0100, Thomas Goirand wrote:
>> Version 20 of openstack-pkg-tools indeed fixed the issues with systemd, and
>> daemons are started properly with it now, though it broke the creation of
>> /var/run/${PROJECT_NAME}, because the init scripts are using $USER, which
>> doesn't seem to be available in sysv-rc scripts.
>>
>> This version 21 replaces the use of $USER by a call to `whoami` which fixes
>> the issue (eg: no error displayed on boot failing to create the PID file,
>> when I tested it using sysv-init-core).
>>
>> This version 21 also fixes a minor issue with upstart (though I'm not sure
>> if this even has consequence, I felt bad to leave it unfixed).
>>
>> Please unblock package openstack-pkg-tools version 21. Debdiff attached.
> 
> This request looks reasonable.
> 
> Could you clarify if this needs new uploads for all the openstack packages
> using these templates? If so, could you upload them all at once, and give us a
> single list of packages to unblock? Remove the moreinfo tag from this bug at
> that point.
> 
> Cheers,
> 
> Ivo

Hi Ivo,

Thanks for your quick reply.

Yes, we do need to rebuild all packages. I've already started doing so,
though for a few packages, I also added the removal of the use of the
ssl.PROTOCOL_SSLv3 object, which doesn't work since we disabled SSLv3 in
Python. Nothing I'm worried about though, because there's been already
some unblock for it.

I'll let you know when I'm done uploading them all. It may take a few
days to do it properly (check all unit tests are correct, etc.).

Cheers,

Thomas Goirand (zigo)


Reply to: