[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#768072: marked as done (unblock: rdesktop/1.8.2-3)

Your message dated Tue, 04 Nov 2014 19:19:03 +0000
with message-id <1415128743.5807.21.camel@adam-barratt.org.uk>
and subject line Re: Bug#768072: unblock: rdesktop/1.8.2-3
has caused the Debian Bug report #768072,
regarding unblock: rdesktop/1.8.2-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
768072: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768072
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear Release Team,

Please consider the latest upload of rdesktop. The bug it fixes[1] is
far from being RC. But it would be a shame that a Windows remote desktop
solution can't use the Windows key in Jessie. The fix is from
upstream[2] and a very trivial two liners.

Debdiff is attached.

Thanks,
Laszlo/GCS

unblock rdesktop/1.8.2-3

[1] http://bugs.debian.org/768066
[2] http://sourceforge.net/p/rdesktop/code/1816/

diff -Nru rdesktop-1.8.2/debian/changelog rdesktop-1.8.2/debian/changelog
--- rdesktop-1.8.2/debian/changelog	2014-10-16 16:22:13.000000000 +0000
+++ rdesktop-1.8.2/debian/changelog	2014-11-04 17:16:05.000000000 +0000
@@ -1,3 +1,9 @@
+rdesktop (1.8.2-3) unstable; urgency=low
+
+  * Backport fix to handle Windows key (closes: #768066).
+
+ -- Laszlo Boszormenyi (GCS) <gcs@debian.org>  Tue, 04 Nov 2014 17:06:04 +0000
+
 rdesktop (1.8.2-2) unstable; urgency=medium
 
   * Update config.{sub,guess} for the AArch64 port (closes: #727953).
diff -Nru rdesktop-1.8.2/debian/patches/Fix_constant_naming_and_enabled_windowskey_by_default.patch rdesktop-1.8.2/debian/patches/Fix_constant_naming_and_enabled_windowskey_by_default.patch
--- rdesktop-1.8.2/debian/patches/Fix_constant_naming_and_enabled_windowskey_by_default.patch	1970-01-01 00:00:00.000000000 +0000
+++ rdesktop-1.8.2/debian/patches/Fix_constant_naming_and_enabled_windowskey_by_default.patch	2014-11-04 17:08:32.000000000 +0000
@@ -0,0 +1,22 @@
+--- a/constants.h
++++ b/constants.h
+@@ -321,7 +321,7 @@
+ #define RDP_LOGON_AUTO		0x0008
+ #define RDP_LOGON_NORMAL	0x0033
+ #define RDP_LOGON_COMPRESSION	0x0080	/* mppc compression with 8kB histroy buffer */
+-#define RDP_LOGON_BLOB		0x0100
++#define RDP_LOGON_ENABLEWINDOWSKEY 0x0100
+ #define RDP_LOGON_COMPRESSION2	0x0200	/* rdp5 mppc compression with 64kB history buffer */
+ #define RDP_LOGON_LEAVE_AUDIO	0x2000
+ #define RDP_LOGON_PASSWORD_IS_SC_PIN 0x40000
+--- a/rdesktop.c
++++ b/rdesktop.c
+@@ -562,7 +562,7 @@
+ 	act.sa_flags = 0;
+ 	sigaction(SIGPIPE, &act, NULL);
+ 
+-	flags = RDP_LOGON_NORMAL;
++	flags = RDP_LOGON_NORMAL | RDP_LOGON_ENABLEWINDOWSKEY;
+ 	prompt_password = False;
+ 	g_seamless_spawn_cmd[0] = domain[0] = g_password[0] = shell[0] = directory[0] = 0;
+ 	g_embed_wnd = 0;
diff -Nru rdesktop-1.8.2/debian/patches/series rdesktop-1.8.2/debian/patches/series
--- rdesktop-1.8.2/debian/patches/series	2014-08-31 15:14:15.000000000 +0000
+++ rdesktop-1.8.2/debian/patches/series	2014-11-04 17:09:42.000000000 +0000
@@ -19,3 +19,4 @@
 01_paging.patch
 20_update_manpage.dpatch
 80_handle_nostrip_option.dpatch
+Fix_constant_naming_and_enabled_windowskey_by_default.patch

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message --- 
On Tue, 2014-11-04 at 19:22 +0100, Laszlo Boszormenyi (GCS) wrote:
> Please consider the latest upload of rdesktop. The bug it fixes[1] is
> far from being RC. But it would be a shame that a Windows remote desktop
> solution can't use the Windows key in Jessie. The fix is from
> upstream[2] and a very trivial two liners.

I could be persuaded that it qualifies as important, given how
frequently used the key is; unblocked, thanks.

Regards,

Adam

--- End Message ---
Reply to: