[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#767724: marked as done (unblock: viewpdf.app/1:0.2dfsg1-5)

Your message dated Sun, 02 Nov 2014 11:49:27 +0100
with message-id <54560C37.5030409@thykier.net>
and subject line Re: Bug#767724: unblock: viewpdf.app/1:0.2dfsg1-5
has caused the Debian Bug report #767724,
regarding unblock: viewpdf.app/1:0.2dfsg1-5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
767724: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767724
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package viewpdf.app, it fixes RC bug #756588.

unblock viewpdf.app/1:0.2dfsg1-5

diff --git a/debian/changelog b/debian/changelog
index 561b471..3b25078 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+viewpdf.app (1:0.2dfsg1-5) unstable; urgency=medium
+
+  * debian/patches/fix-NSView-crash.patch: New; fix a crash on i386 when
+    opening a PDF file (Closes: #756588).
+  * debian/patches/series: Update.
+
+ -- Yavor Doganov <yavor@gnu.org>  Fri, 31 Oct 2014 18:33:36 +0200
+
 viewpdf.app (1:0.2dfsg1-4) unstable; urgency=low
 
   * debian/control (Maintainer, Uploaders): Adopt package, make the
diff --git a/debian/patches/fix-NSView-crash.patch b/debian/patches/fix-NSView-crash.patch
new file mode 100644
index 0000000..18bd9a5
--- /dev/null
+++ b/debian/patches/fix-NSView-crash.patch
@@ -0,0 +1,29 @@
+Description: Fix crash on i386 when opening a PDF file.
+Author: Yavor Doganov <yavor@gnu.org>
+Bug-Debian: https://bugs.debian.org/756588
+Forwarded: not-needed
+Last-Update: 2014-10-31
+---
+
+--- vindaloo.app.orig/CenteringClipView.m
++++ vindaloo.app/CenteringClipView.m
+@@ -28,6 +28,9 @@
+ 
+ - (void) centerDocumentView
+ {
++  if (![self documentView])
++    return;
++
+    NSRect docRect = [[self documentView] frame];
+    NSRect clipRect = [self bounds];
+ 
+@@ -53,6 +56,9 @@
+ // origin point.
+ - (NSPoint) constrainScrollPoint: (NSPoint)proposedNewOrigin
+ {
++  if (![self documentView])
++    return [self bounds].origin;
++
+    NSRect docRect = [[self documentView] frame];
+    NSRect clipRect = [self bounds];
+    NSPoint newScrollPoint = proposedNewOrigin;
diff --git a/debian/patches/series b/debian/patches/series
index ab5a9c3..e2c00af 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
+fix-NSView-crash.patch
 rename.patch

--- End Message ---
--- Begin Message --- 
On 2014-11-02 07:47, Yavor Doganov wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package viewpdf.app, it fixes RC bug #756588.
> 
> unblock viewpdf.app/1:0.2dfsg1-5
> 


Hi,

Sorry, but I will have to decline your request.  The RC bug does not
affect testing (as gnustep-dl is not in testing) and therefore not
applicable for neither ageing nor an unblock.

Yours truly,
~Niels

--- End Message ---
Reply to: