Re: Please avoid upgrading to django1.7 before Jessie

[Raphael Hertzog <hertzog@debian.org>]

Control: tags -1 patch

Hello Neil,

On Sun, 03 Aug 2014, Neil Williams wrote:
> I've now been able to test django-restricted-resource against django1.7
> and what I thought should be a simple test has shown significant issues.
>
> The changes in django1.7 cause breakage in the
> django-restricted-resource testsuite and there will be insufficient
> time to fix the test suite (and likely the packages which depend on
> django-restricted-resource) ahead of the Jessie freeze.

Really?

I looked into your package. It needs a 3 line patch for the testsuite:
$ git diff
diff --git a/django_restricted_resource/tests.py b/django_restricted_resource/tests.py
index 8dd1d91..5619eb0 100644
--- a/django_restricted_resource/tests.py
+++ b/django_restricted_resource/tests.py
@@ -34,6 +34,10 @@ from django_restricted_resource.test_utils import (
 
 from django_restricted_resource.models import RestrictedResource
 
+import django
+if hasattr(django, 'setup'):
+    django.setup()
+
 
 class ResourceCleanTests(FixtureHelper, TestCase):
 

And now:
$ ./setup.py test
Ran 172 tests in 1.737s

OK
Destroying test database for alias 'default' (':memory:')...

> Please do not upload django1.7 to unstable at this time.

Please do not pretend you have done a serious investigation when you
haven't.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Discover the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/