[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

not fixed (udev dependency now causing FTBFS)



Control: notfixed -1 4.1-1
Control: tag -1 patch
Control: block 728919 with -1

Hi,

The dependency of qthid-fcd-controller on udev is not gratuitous. It's no use to
put the B-D in libudev in [linux-any] filter and demote the Depends to Recommends
because the code attempts to use libudev unconditionally (see qthid.pro and hidraw.c).

Here's a patch which fixes the build problem by reverting the old behaviour on
non-Linux platforms.

Note: please respond as soon as possible, as this problem blocks the freebsd-libs
transition.

Thanks!

-- 
Robert Millan
diff -ur qthid-fcd-controller-4.1/qthid.pro qthid-fcd-controller-4.1.new/qthid.pro
--- qthid-fcd-controller-4.1/qthid.pro	2014-02-01 14:53:42.000000000 +0100
+++ qthid-fcd-controller-4.1.new/qthid.pro	2014-02-01 14:52:12.989040881 +0100
@@ -60,11 +60,12 @@
 
 # libusb-1.0 on Linux uses pkg-config
 linux-g++|linux-g++-64 {
-#    CONFIG += link_pkgconfig
-#    PKGCONFIG += libusb-1.0
-#    SOURCES += hid-libusb.c
     LIBS += -ludev
     SOURCES += hidraw.c
+} else {
+    CONFIG += link_pkgconfig
+    PKGCONFIG += libusb-1.0
+    SOURCES += hid-libusb.c
 }
 
 RESOURCES += \

Reply to: