--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package libverto
Hi. It turns out that verto_setflags is broken against the
libverto-libev module, which is the one Debian uses basically all the
time. As a result, krb5-kdc cannot act as an OTP preauth server. The
fix is quite simple and I request pre-approval to upload it. I could
make an argument that this is RC against libverto as it breaks a
significant feature of krb5-kdc.
diff --git a/debian/changelog b/debian/changelog
index 0bed159..5716c01 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+libverto (0.2.4-2) unstable; urgency=medium
+
+ * Fix libverto-libev's setflags handling, Closes: #773778
+ - Without this fix, RADIUS support in krb5-kdc is entirely broken,
+ which prevents Debian from being a server for OTP preauth.
+ *
+
+ -- Sam Hartman <hartmans@debian.org> Mon, 29 Dec 2014 20:17:46 -0500
+
libverto (0.2.4-1) unstable; urgency=low
* Update to new upstream
diff --git a/src/verto-libev.c b/src/verto-libev.c
index 2eb08fc..9c7c324 100644
--- a/src/verto-libev.c
+++ b/src/verto-libev.c
@@ -106,7 +106,9 @@ libev_ctx_set_flags(verto_mod_ctx *ctx, const verto_ev *ev,
if (verto_get_flags(ev) & VERTO_EV_FLAG_IO_WRITE)
events |= EV_WRITE;
+ ev_io_stop(ctx, (ev_io*) evpriv);
ev_io_set(((ev_io*) evpriv), verto_get_fd(ev), events);
+ ev_io_start(ctx, (ev_io*) evpriv);
}
}
@@ -131,7 +133,6 @@ libev_ctx_add(verto_mod_ctx *ctx, const verto_ev *ev, verto_ev_flag *flags)
} w;
ev_tstamp interval;
-
w.watcher = NULL;
*flags |= VERTO_EV_FLAG_PERSIST;
switch (verto_get_type(ev)) {
unblock libverto/0.2.4-2
-- System Information:
Debian Release: jessie/sid
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable'), (250, 'testing'), (200, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- End Message ---
--- Begin Message ---
On Tue, 2014-12-30 at 05:54 +0000, Adam D. Barratt wrote:
> Control: tags -1 + confimred moreinfo
>
> On Mon, 2014-12-29 at 20:25 -0500, Sam Hartman wrote:
> > Hi. It turns out that verto_setflags is broken against the
> > libverto-libev module, which is the one Debian uses basically all the
> > time. As a result, krb5-kdc cannot act as an OTP preauth server. The
> > fix is quite simple and I request pre-approval to upload it. I could
> > make an argument that this is RC against libverto as it breaks a
> > significant feature of krb5-kdc.
>
> Please go ahead, and remove the "moreinfo" tag once the package has been
> accepted.
The raw debdiff turns out to be quite horrible:
changelog | 9
patches/debian-changes | 5772
++++++++++++++++++++++++-------------------------
2 files changed, 2905 insertions(+), 2876 deletions(-)
The interdiff of the patch from the unpacked source packages looks fine,
so unblocked.
As a note for a future upload, there's an empty entry in the changelog
stanza:
+ *
Regards,
Adam
--- End Message ---