[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#773360: marked as done (unblock: vala-mode-el/0.1-2)



Your message dated Fri, 26 Dec 2014 22:31:48 +0100
with message-id <20141226213148.GA23890@ugent.be>
and subject line Re: Bug#773360: unblock: vala-mode-el/0.1-2
has caused the Debian Bug report #773360,
regarding unblock: vala-mode-el/0.1-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
773360: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773360
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package vala-mode-el

There is a bug in vala-mode-el 0.1-1 which causes an installation
failure when emacs24 is installed.  Jessie will ship with emacs24.

The relevant bugs:

    768159    error upgrading emacs
    702714    warning during the byte compilation

Here is the debian/changelog entry:

    vala-mode-el (0.1-2) unstable; urgency=medium

      * Patch away `(lambda ... ,foo ...) ickiness (closes: #702714)
      * Source option single-debian-patch for in-tree rather than quilt patch
      * Bump debian standards version (no changes required)
      * Update upstream location
      * Fix grammar in comment in source code
      * Add support to use C# semantics when ECB and CEDIT are both installed

     -- Barak A. Pearlmutter <bap@debian.org>  Wed, 05 Nov 2014 11:07:16 +0000

Here is a debdiff:

    $ debdiff vala-mode-el_0.1-{1,2}*.deb
    [The following lists of changes regard files as different if they have
    different names, permissions or owners.]

    Files in second .deb but not in first
    -------------------------------------
    -rw-r--r--  root/root   /usr/lib/emacsen-common/packages/compat/vala-mode-el

    Control files: lines which differ (wdiff format)
    ------------------------------------------------
    Homepage: [-https://live.gnome.org/Vala/Emacs-] {+https://wiki.gnome.org/Projects/Vala/Emacs+}
    Version: [-0.1-1-] {+0.1-2+}

Here is the actual source code change:

    $ git diff debian/0.1-1..debian/0.1-2 --word-diff -- $(ls -A|egrep -v '^debian$')

    diff --git a/vala-mode.el b/vala-mode.el
    index d125540..5265b9b 100644
    --- a/vala-mode.el
    +++ b/vala-mode.el
    @@ -1,4 +1,4 @@
    ;;; vala-mode.el --- Vala mode derived mode {+-*- lexical-binding: t -*-+}

    ;; Author:     2005 Dylan R. E. Moonfire
    ;;	       2008 Étienne BERSAC
    @@ -46,6 +46,8 @@
    ;;	0.1	: Initial version based on csharp-mode
    ;;

    {+(require 'cl)+}

    ;; This is a copy of the function in cc-mode which is used to handle
    ;; the eval-when-compile which is needed during other times.
    (defun c-filter-ops (ops opgroup-filter op-filter &optional xlate)
    @@ -55,13 +57,15 @@
      (cond ((eq opgroup-filter t)
	     (setq opgroup-filter (lambda (opgroup) t)))
	    ((not (functionp opgroup-filter))
	     {+(let ((opgroup-filter-orig opgroup-filter))+}
	       (setq opgroup-filter [-`(lambda-]{+(lambda+} (opgroup)
				      (memq opgroup [-',opgroup-filter)))))-]{+opgroup-filter-orig))))))+}
      (cond ((eq op-filter t)
	     (setq op-filter (lambda (op) t)))
	    ((stringp op-filter)
	     {+(let ((op-filter-orig op-filter))+}
	       (setq op-filter [-`(lambda-]{+(lambda+} (op)
				 (string-match [-,op-filter op)))))-]{+op-filter-orig op))))))+}
      (unless xlate
	(setq xlate 'identity))
      (c-with-syntax-table (c-lang-const c-mode-syntax-table)
    @@ -149,22 +153,20 @@
	     ;; Fontify leading identifiers in fully
	     ;; qualified names like "Foo.Bar".
	     ,@(when (c-lang-const c-opt-identifier-concat-key)
		 [-`((,(byte-compile-]
    [-		  `(lambda (limit)-]
    [-		     (while (re-search-forward-]
    [-			     ,(concat-]{+(let ((regexp (concat+} "\\(\\<" ; 1
				       "\\(" (c-lang-const c-symbol-key)
				       "\\)" ; 2
				       "[ \t\n\r\f\v]*"
				       (c-lang-const
					c-opt-identifier-concat-key)
				       "[ \t\n\r\f\v]*"
				       "\\)"
				       "\\("
				       (c-lang-const
					c-opt-after-id-concat-key)
				       [-"\\)")-]{+"\\)")))+}
    {+	       `((,(lambda (limit)+}
    {+		     (while (re-search-forward regexp+} limit t)
			   (unless (progn
				     (goto-char (match-beginning 0))
				     (c-skip-comments-and-strings limit))

unblock vala-mode-el/0.1-2

-- System Information:
Debian Release: 8.0
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message ---
Hi,

On Wed, Dec 17, 2014 at 11:21:46PM +0000, Barak A. Pearlmutter wrote:
> I think that covers everything.

Unblocked.

Cheers,

Ivo

--- End Message ---

Reply to: