[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#773163: unblock: systemd/215-8



Hey Adam,

Adam D. Barratt [2014-12-15 19:16 +0000]:
> There's something slightly odd about introducing a file that says "This
> file is not intended to be distributed". :-)

Oops, that looks like an overzealous copy & paste error.

> Unblocked, but will as ever need a d-i ack.

Cheers!

> See also #773183 if you haven't already.

Applied in git now, will be in -9.

> A couple of minor points:
> 
> ++        /* we only create the alias symlink for non sysvinit services */
> ++        if (access(target_unit_path, F_OK) < 0 && (errno == ENOENT)) {
> ++                log_warning("%s doesn't seem to be a system unit, we disable the systemd enabled display manager", target_unit_path);
> 
> Should that be "systemd unit"?

Yes, and the "doesn't seem to be" is unnecessarily doubtful.

> ++                log_warning("%s point at %s while the default systemd unit is %s. Reconfiguring %s as default.",
> 
> s/point/points/

Indeed.

I fixed the three issues in
http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=dc0a50b23fd
so they will be in -9.

Thanks!

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Attachment: signature.asc
Description: Digital signature


Reply to: