--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Dear release team,
The package weboob has been marked for autoremoval because of a RC bug
introduced by a patch made on Python to remove a deprecated constant
(PROTOCOL_SSLv3) which breaks weboob:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768611
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771499
To fix this issue, I've uploaded a new version of the package in unstable which
removes the use of this constant, and replaces it with PROTOCOL_SSLv23 (bad
named, it chooses the highest protocol version, cf
https://docs.python.org/2/library/ssl.html#ssl.PROTOCOL_SSLv23).
diff -Nru weboob-1.0/debian/changelog weboob-1.0/debian/changelog
--- weboob-1.0/debian/changelog 2014-10-20 22:16:20.000000000 +0200
+++ weboob-1.0/debian/changelog 2014-12-10 10:05:31.000000000 +0100
@@ -1,3 +1,11 @@
+weboob (1.0-2) unstable; urgency=low
+
+ * debian/patches/0003-fix-compatibility-with-a-patch-introduced-by-768611.patch:
+ disable SSLv3 to be compliant with changes introduced by #768611 in Python
+ (Closes: #771499).
+
+ -- Romain Bignon <romain@symlink.me> Mon, 08 Dec 2014 20:25:54 +0100
+
weboob (1.0-1) unstable; urgency=low
* New Upstream Release
diff -Nru weboob-1.0/debian/patches/0002-fix-StatusField-to-be-a-BaseObject.patch weboob-1.0/debian/patches/0002-fix-StatusField-to-be-a-BaseObject.patch
--- weboob-1.0/debian/patches/0002-fix-StatusField-to-be-a-BaseObject.patch 2014-10-20 22:16:20.000000000 +0200
+++ weboob-1.0/debian/patches/0002-fix-StatusField-to-be-a-BaseObject.patch 2014-12-10 10:05:31.000000000 +0100
@@ -3,11 +3,11 @@
Subject: fix StatusField to be a BaseObject
---
- weboob/capabilities/account.py | 12 +++++++++---
- 1 file changed, 9 insertions(+), 3 deletions(-)
+ weboob/capabilities/account.py | 10 ++++++++--
+ 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/weboob/capabilities/account.py b/weboob/capabilities/account.py
-index 0acd88d..cfac8a5 100644
+index 0acd88d..a742377 100644
--- a/weboob/capabilities/account.py
+++ b/weboob/capabilities/account.py
@@ -18,7 +18,7 @@
diff -Nru weboob-1.0/debian/patches/0003-fix-compatibility-with-a-patch-introduced-by-768611.patch weboob-1.0/debian/patches/0003-fix-compatibility-with-a-patch-introduced-by-768611.patch
--- weboob-1.0/debian/patches/0003-fix-compatibility-with-a-patch-introduced-by-768611.patch 1970-01-01 01:00:00.000000000 +0100
+++ weboob-1.0/debian/patches/0003-fix-compatibility-with-a-patch-introduced-by-768611.patch 2014-12-10 10:05:31.000000000 +0100
@@ -0,0 +1,23 @@
+From: Romain Bignon <romain@symlink.me>
+Date: Mon, 8 Dec 2014 20:20:19 +0100
+Subject: fix compatibility with a patch introduced by #768611
+
+SSLv3 has been disabled in Debian's package of Python, so we have to
+change the protocol constant to use to let browser work.
+---
+ weboob/deprecated/browser/browser.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/weboob/deprecated/browser/browser.py b/weboob/deprecated/browser/browser.py
+index e85b701..61ebbd3 100644
+--- a/weboob/deprecated/browser/browser.py
++++ b/weboob/deprecated/browser/browser.py
+@@ -730,7 +730,7 @@ socket.getaddrinfo = my_getaddrinfo
+
+ class HTTPSConnection2(httplib.HTTPSConnection):
+ _HOSTS = {}
+- _PROTOCOLS = [ssl.PROTOCOL_TLSv1, ssl.PROTOCOL_SSLv3]
++ _PROTOCOLS = [ssl.PROTOCOL_TLSv1, ssl.PROTOCOL_SSLv23]
+
+ def _my_create_connection(self):
+ sock = socket.create_connection((self.host, self.port), self.timeout)
diff -Nru weboob-1.0/debian/patches/series weboob-1.0/debian/patches/series
--- weboob-1.0/debian/patches/series 2014-10-20 22:16:20.000000000 +0200
+++ weboob-1.0/debian/patches/series 2014-12-10 10:05:31.000000000 +0100
@@ -1,2 +1,3 @@
0001-Set-copyright-in-applications.patch
0002-fix-StatusField-to-be-a-BaseObject.patch
+0003-fix-compatibility-with-a-patch-introduced-by-768611.patch
Please unblock package weboob
unblock weboob/1.0-2
Regards,
Romain
-- System Information:
Debian Release: jessie/sid
APT prefers testing
APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- End Message ---
--- Begin Message ---
On 2014-12-10 11:36, Romain Bignon wrote:
The package weboob has been marked for autoremoval because of a RC bug
introduced by a patch made on Python to remove a deprecated constant
(PROTOCOL_SSLv3) which breaks weboob:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768611
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771499
To fix this issue, I've uploaded a new version of the package in
unstable which
removes the use of this constant, and replaces it with PROTOCOL_SSLv23
(bad
named, it chooses the highest protocol version, cf
https://docs.python.org/2/library/ssl.html#ssl.PROTOCOL_SSLv23).
Unblocked, thanks.
Regards,
Adam
--- End Message ---