--- Begin Message ---
Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertags: unblock
Severity: normal
Please unblock package vorbis-tools. The version 1.4.0-6, about to be
uploaded to unstable, fixes the following two bugs, both having severity
"important":
* #771363 is about a crash on closing input files of type "raw".
Although the crash happened only after correctly encoding the file, it
can severely affect the tool's usability regarding encoding of multiple
files. The bug was fixed by backporting a commit from the upstream SVN
repository.
* #763338 is about faulty processing of input parameters in the script
"vorbistagedit", which makes it impossible to use the script with
filenames containing spaces.
The changlog entry for 1.4.0-6:
[ Martin Steghöfer ]
* Fix oggenc crash on closing raw input files by backporting r19117
from upstream
(Closes: #771363)
* Fix vorbistagedit: Correctly process input files containing spaces
(Closes: #763338)
Please find attached a debdiff between the version in testing (1.4.0-5)
and the version about to be uploaded (1.4.0-6).
Thanks!
Martin
unblock vorbis-tools/1.4.0-6
-- System Information:
Debian Release: 7.6
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru vorbis-tools-1.4.0/debian/changelog vorbis-tools-1.4.0/debian/changelog
--- vorbis-tools-1.4.0/debian/changelog 2014-11-11 21:49:04.000000000 +0100
+++ vorbis-tools-1.4.0/debian/changelog 2014-12-05 13:16:04.000000000 +0100
@@ -1,3 +1,13 @@
+vorbis-tools (1.4.0-6) UNRELEASED; urgency=medium
+
+ [ Martin Steghöfer ]
+ * Fix oggenc crash on closing raw input files by backporting r19117 from upstream
+ (Closes: #771363)
+ * Fix vorbistagedit: Correctly process input files containing spaces
+ (Closes: #763338)
+
+ -- Martin Steghöfer <martin@steghoefer.eu> Fri, 05 Dec 2014 13:14:24 +0100
+
vorbis-tools (1.4.0-5) unstable; urgency=low
[ Martin Steghöfer ]
diff -Nru vorbis-tools-1.4.0/debian/extra/vorbistagedit vorbis-tools-1.4.0/debian/extra/vorbistagedit
--- vorbis-tools-1.4.0/debian/extra/vorbistagedit 2014-11-11 21:49:04.000000000 +0100
+++ vorbis-tools-1.4.0/debian/extra/vorbistagedit 2014-12-05 13:16:04.000000000 +0100
@@ -32,7 +32,13 @@
exit 1
fi
-for opt in $(getopt -n $ME -l version,help -o Vh? -- "$@"); do
+# process and reorder arguments using "getopt"
+eval set -- $(getopt -s sh -n $ME -l version,help -o Vh? -- "$@")
+
+# process the options (not the filenames yet) and remove them from the argument array
+while [ $# -gt 0 ]
+do
+ opt="$1"
case $opt in
--version|-V)
versioninfo
@@ -40,13 +46,23 @@
--help|-h|-\?)
usage
exit 0;;
- --) :;;
- -*)
+ --)
+ # found "--", which separates options and filenames in "getopt" output;
+ # so we are done parsing the options
+
+ # remove the "--"
+ shift
+
+ # now there are only filenames in the argument array => stop processing
+ break;;
+ *)
echo "E: $ME: invalid argument: $opt" >&2
usage
exit 1;;
- *) :;;
esac
+
+ # remove the processed option from the argument array
+ shift
done
if ! command -v vorbiscomment >/dev/null; then
diff -Nru vorbis-tools-1.4.0/debian/patches/0009-Fix-oggenc-crash-on-closing-raw-input-files.patch vorbis-tools-1.4.0/debian/patches/0009-Fix-oggenc-crash-on-closing-raw-input-files.patch
--- vorbis-tools-1.4.0/debian/patches/0009-Fix-oggenc-crash-on-closing-raw-input-files.patch 1970-01-01 01:00:00.000000000 +0100
+++ vorbis-tools-1.4.0/debian/patches/0009-Fix-oggenc-crash-on-closing-raw-input-files.patch 2014-12-05 13:16:04.000000000 +0100
@@ -0,0 +1,37 @@
+From: =?utf-8?q?Martin_Stegh=C3=B6fer?= <martin@steghoefer.eu>
+Date: Sat, 29 Nov 2014 10:57:11 +0100
+Subject: Fix oggenc crash on closing raw input files
+
+Origin: backport, https://trac.xiph.org/changeset/19117/trunk/vorbis-tools/oggenc
+Author: Gregory Maxwell <greg@xiph.org>
+Bug-Debian: https://bugs.debian.org/771363
+
+Fixes a crash of oggenc on closing of any raw input file. The problem was
+a function call using a function pointer that had become invalid when
+a variable that was still referenced by a pointer ran out of scope.
+---
+ oggenc/oggenc.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/oggenc/oggenc.c b/oggenc/oggenc.c
+index 5c36fea..7ad9303 100644
+--- a/oggenc/oggenc.c
++++ b/oggenc/oggenc.c
+@@ -97,6 +97,8 @@ int main(int argc, char **argv)
+ .3,-1,
+ 0,0,0.f,
+ 0, 0, 0, 0, 0};
++ input_format raw_format = {NULL, 0, raw_open, wav_close, "raw",
++ N_("RAW file reader")};
+
+ int i;
+
+@@ -239,8 +241,6 @@ int main(int argc, char **argv)
+
+ if(opt.rawmode)
+ {
+- input_format raw_format = {NULL, 0, raw_open, wav_close, "raw",
+- N_("RAW file reader")};
+
+ enc_opts.rate=opt.raw_samplerate;
+ enc_opts.channels=opt.raw_channels;
diff -Nru vorbis-tools-1.4.0/debian/patches/series vorbis-tools-1.4.0/debian/patches/series
--- vorbis-tools-1.4.0/debian/patches/series 2014-11-11 21:49:04.000000000 +0100
+++ vorbis-tools-1.4.0/debian/patches/series 2014-12-05 13:16:04.000000000 +0100
@@ -5,3 +5,4 @@
fix_xiph_url.diff
fix-ogg123-freeze-when-interrupting-at-end-of-stream.patch
documentation-of-link-between-f-and-d-flag.patch
+0009-Fix-oggenc-crash-on-closing-raw-input-files.patch
--- End Message ---