[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#772091: marked as done (unblock: squid3/3.4.8-4)



Your message dated Fri, 5 Dec 2014 13:44:34 +0100
with message-id <20141205124434.GH14303@ugent.be>
and subject line Re: Bug#772091: unblock: squid3/3.4.8-4
has caused the Debian Bug report #772091,
regarding unblock: squid3/3.4.8-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
772091: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772091
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: important
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package squid3 before stricter freeze policy applies

3.4.8-3 fixes an important bug (#768170) which prevents squid3 from starting after upgrade from wheezy with standard config.

--- squid3-3.4.8/debian/changelog	2014-10-29 15:51:34.000000000 +0100
+++ squid3-3.4.8/debian/changelog	2014-12-05 01:28:34.000000000 +0100
@@ -1,3 +1,17 @@
+squid3 (3.4.8-3) unstable; urgency=medium
+
+  [ Amos Jeffries <amosjeffries@squid-cache.org> ]
+  * debian/squid3.preinst
+    - Remove obsolete manager ACL definition from squid.conf
+      when upgrading squid3 package (Closes: #768170)
+
+
+  [ Luigi Gangitano <luigi@debian.org> ]
+  * debian/squid3.preinst
+    - Fix configuration file only if needed and match any uncommented line
+
+ -- Luigi Gangitano <luigi@debian.org>  Fri,  5 Dec 2014 01:27:51 +0100
+
 squid3 (3.4.8-2) unstable; urgency=medium
 
   [ Santiago Garcia Mantinan <manty@debian.org> ]
diff -Nru squid3-3.4.8/debian/squid3.preinst squid3-3.4.8/debian/squid3.preinst
--- squid3-3.4.8/debian/squid3.preinst	2014-10-29 15:51:34.000000000 +0100
+++ squid3-3.4.8/debian/squid3.preinst	2014-12-05 01:28:34.000000000 +0100
@@ -4,8 +4,24 @@
 
 case "$1" in
 	upgrade|install-upgrade)
+		#
+		# Remove obsolete manager ACL definition.
+		# It will halt upgrade with fatal error if left.
+		#
+		if test -f /etc/squid3/squid.conf && dpkg --compare-versions "$2" lt '3.4.8-3' && grep -q "^[[:blank:]]*acl manager" /etc/squid3/squid.conf ; then
+			echo "Filtering squid.conf manager ACL."
+			cp /etc/squid3/squid.conf /etc/squid3/squid.conf.pre_3.4_upgrade
+			sed -e "s/^\([ \t]*acl manager.*\)/# \1 # Commented out on upgrade to 3.4/" </etc/squid3/squid.conf.pre_3.4_upgrade >/etc/squid3/squid.conf
+		fi
 		;;
 	abort-upgrade)
+		#
+		# Revert the automated configuration changes we may have done
+		#
+		if test -f /etc/squid3/squid.conf.upgrade-backup; then
+			echo "Removing squid.conf changes."
+			mv /etc/squid3/squid.conf.upgrade-backup /etc/squid3/squid.conf
+		fi
 		exit 0
 		;;
 esac


unblock squid3/3.4.8-3

-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 3.16.0-4-686-pae (SMP w/2 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: sysvinit (via /sbin/init)

--- End Message ---
--- Begin Message ---
Hi,

On Fri, Dec 05, 2014 at 10:57:04AM +0100, Luigi Gangitano wrote:
> I uploaded a new version with a small fix to preinst script. Please see
> below the debdiff since version currently in testing (3.4.8-2).

Unblocked.

Cheers,

Ivo

--- End Message ---

Reply to: