[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#771919: marked as done (unblock: qtmultimedia-opensource-src/5.3.2-5)

Your message dated Wed, 3 Dec 2014 23:15:39 +0100
with message-id <20141203221539.GA5308@ugent.be>
and subject line Re: Bug#771919: unblock: qtmultimedia-opensource-src/5.3.2-4
has caused the Debian Bug report #771919,
regarding unblock: qtmultimedia-opensource-src/5.3.2-5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
771919: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771919
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package qtmultimedia-opensource-src

qtmultimedia was not building the ALSA plugin needed to support it
when pulseaudio support was present.

The fix is just two lines plus one new entry in a install file.

I have just tested it in a system without pulse and on a system with pulse
and it works as it should.

I really think this complies with the release unblock rules so I just pushed
the package too.

Kinds regards, Lisandro.

unblock qtmultimedia-opensource-src/5.3.2-4

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru qtmultimedia-opensource-src-5.3.2/debian/changelog qtmultimedia-opensource-src-5.3.2/debian/changelog
--- qtmultimedia-opensource-src-5.3.2/debian/changelog	2014-10-15 12:46:33.000000000 -0300
+++ qtmultimedia-opensource-src-5.3.2/debian/changelog	2014-12-03 10:37:17.000000000 -0300
@@ -1,3 +1,11 @@
+qtmultimedia-opensource-src (5.3.2-4) unstable; urgency=medium
+
+  * Add a patch from Chris Ruvolo to also build the ALSA plugin even if we
+    are building with pulseaudio support (Closes: #771391).
+    - Include the plugin in libqt5multimedia5-plugins' install file.
+
+ -- Lisandro Damián Nicanor Pérez Meyer <lisandro@debian.org>  Wed, 03 Dec 2014 10:37:12 -0300
+
 qtmultimedia-opensource-src (5.3.2-3) unstable; urgency=medium
 
   * Remove CMake files for plugins, we don't need to ship them
diff -Nru qtmultimedia-opensource-src-5.3.2/debian/libqt5multimedia5-plugins.install qtmultimedia-opensource-src-5.3.2/debian/libqt5multimedia5-plugins.install
--- qtmultimedia-opensource-src-5.3.2/debian/libqt5multimedia5-plugins.install	2014-09-17 19:55:18.000000000 -0300
+++ qtmultimedia-opensource-src-5.3.2/debian/libqt5multimedia5-plugins.install	2014-12-03 10:35:54.000000000 -0300
@@ -1,3 +1,4 @@
+usr/lib/*/qt5/plugins/audio/libqtaudio_alsa.so
 usr/lib/*/qt5/plugins/audio/libqtmedia_pulse.so
 usr/lib/*/qt5/plugins/audio/libqtmedia_pulse.so
 usr/lib/*/qt5/plugins/mediaservice/libgstaudiodecoder.so
diff -Nru qtmultimedia-opensource-src-5.3.2/debian/patches/also_build_alsa_plugin.patch qtmultimedia-opensource-src-5.3.2/debian/patches/also_build_alsa_plugin.patch
--- qtmultimedia-opensource-src-5.3.2/debian/patches/also_build_alsa_plugin.patch	1969-12-31 21:00:00.000000000 -0300
+++ qtmultimedia-opensource-src-5.3.2/debian/patches/also_build_alsa_plugin.patch	2014-12-03 10:12:36.000000000 -0300
@@ -0,0 +1,27 @@
+Description: Build alsa plugin in addition to pulseaudio.
+ Even if pulse audio is present, we still want to build the alsa plugin.
+ .
+ qtmultimedia-opensource-src (5.3.2-2~bpo70+2.1) wheezy-backports; urgency=medium
+ .
+   * Build alsa plugin in addition to pulseaudio.
+Author: Chris Ruvolo <cruvolo+deb@gmail.com>
+Bug-Debian: http://bugs.debian.org/771391
+Last-Update: 2014-12-02
+
+---
+ src/plugins/plugins.pro |    4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+--- a/src/plugins/plugins.pro
++++ b/src/plugins/plugins.pro
+@@ -38,7 +38,9 @@ unix:!mac:!android {
+ 
+     config_pulseaudio {
+         SUBDIRS += pulseaudio
+-    } else:config_alsa {
++    }
++
++    config_alsa {
+         SUBDIRS += alsa
+     }
+ 
diff -Nru qtmultimedia-opensource-src-5.3.2/debian/patches/series qtmultimedia-opensource-src-5.3.2/debian/patches/series
--- qtmultimedia-opensource-src-5.3.2/debian/patches/series	2014-09-22 23:26:26.000000000 -0300
+++ qtmultimedia-opensource-src-5.3.2/debian/patches/series	2014-12-03 10:10:29.000000000 -0300
@@ -1 +1,2 @@
+also_build_alsa_plugin.patch
 rpath_nonlinux.diff

--- End Message ---
--- Begin Message --- 
Hi Lisandro,

On Wed, Dec 03, 2014 at 01:21:11PM -0300, Lisandro Damián Nicanor Pérez Meyer wrote:
> Uups, the fix breaks the BSDs, which is also an easy fix: do not install the 
> plugin on *bsd. Do you think it's worth to fix it? Or should I leave it as it 
> is?

Unblocked qtmultimedia-opensource-src/5.3.2-5

Cheers,

Ivo

--- End Message ---
Reply to: