[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#771574: unblock (pre-approval): vim/2:7.4.488-3



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package vim

As described in #765069[0], there was a recent change in GTK+ 3.14
with regard to icon scaling occurs.  The result being that Vim's icon in
Gnome's "Open with..." dialog is vastly oversized, resulting in a bad
user experience trying to choose a non-default application to handle a
file.

[0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=765069#49

The trivial work around I'd like to upload is to install Vim's icons
into /usr/share/icons/hicolor so GTK's icon handling understands that
vim.svg is scalable.

$ debdiff vim_7.4.488-2.dsc vim_7.4.488-3.dsc
dpkg-source: warning: extracting unsigned source package (/home/jamessan/src/debian.org/deb-packages/vim/vim_7.4.488-3.dsc)
diffstat for vim-7.4.488 vim-7.4.488

 changelog                 |    7 +++++++
 vim-gui-common.install.in |    3 +++
 2 files changed, 10 insertions(+)

diff -Nru vim-7.4.488/debian/changelog vim-7.4.488/debian/changelog
--- vim-7.4.488/debian/changelog	2014-11-14 21:06:33.000000000 -0500
+++ vim-7.4.488/debian/changelog	2014-11-30 15:08:12.000000000 -0500
@@ -1,3 +1,10 @@
+vim (2:7.4.488-3) unstable; urgency=medium
+
+  * Install icons to /usr/share/icons/hicolor to work around #765069.
+    (Closes: #768256)
+
+ -- James McCoy <jamessan@debian.org>  Sun, 30 Nov 2014 15:08:09 -0500
+
 vim (2:7.4.488-2) unstable; urgency=medium
 
   * Actually fix the Name in vim.desktop.  (Closes: #769575)
diff -Nru vim-7.4.488/debian/vim-gui-common.install.in vim-7.4.488/debian/vim-gui-common.install.in
--- vim-7.4.488/debian/vim-gui-common.install.in	2014-10-22 21:01:13.000000000 -0400
+++ vim-7.4.488/debian/vim-gui-common.install.in	2014-11-30 14:34:27.000000000 -0500
@@ -1,6 +1,9 @@
 debian/tmp/usr/bin/gvimtutor				usr/bin/
 debian/gvim.desktop					usr/share/applications/
 debian/icons/*						usr/share/pixmaps/
+debian/icons/vim.svg					usr/share/icons/hicolor/scalable/apps/
+debian/icons/vim-16.xpm					usr/share/icons/hicolor/16x16/apps/vim.xpm
+debian/icons/vim-32.xpm					usr/share/icons/hicolor/32x32/apps/vim.xpm
 debian/runtime/gvimrc					etc/vim/
 debian/tmp/usr/share/man/man1/evim.1			usr/share/man/man1/
 debian/lintian/vim-gui-common				usr/share/lintian/overrides/

unblock vim/2:7.4.488-3

-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


Reply to: