--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please see bug #771408 for background.
Spamassassin upstream has recently introduced the ability for rule
authors to query for the perl version, which had previously not been
visible to rules. The intent is to allow authors to conditionally enable
rules based on the availability of newer perl features.
We don't have any actual metrics on this, but it's likely that a large
percentage of Debian spamassassin users enable the optional nightly cron
job that updates the installed spam detection rules. Unfortunately,
unless we backport the ability to query the perl version, our users will
see warnings on every invocation of spamassassin, sa-learn, sa-update,
and possibly others, as authors start implementing rules that depend on
this perl version check. Since these programs are often run from cron
and on incoming email, this leads to lots of annoying cron-spam.
I've recently uploaded 3.4.0-5 to unstable. The only change from 3.4.0-4
is the backport of the perl version query functionality. Please see the
attached debdiff.
(Note that stable users are impacted by this and will need a similar
fix; I'll file a similar request for s-p-u when I have a fix.)
Thanks
noah
diff -Nru spamassassin-3.4.0/debian/changelog spamassassin-3.4.0/debian/changelog
--- spamassassin-3.4.0/debian/changelog 2014-11-22 17:10:29.000000000 -0800
+++ spamassassin-3.4.0/debian/changelog 2014-11-29 14:29:29.000000000 -0800
@@ -1,3 +1,9 @@
+spamassassin (3.4.0-5) unstable; urgency=medium
+
+ * Import upstream fix for perl_version warnings (Closes: 771408)
+
+ -- Noah Meyerhans <noahm@debian.org> Sat, 29 Nov 2014 11:48:48 -0800
+
spamassassin (3.4.0-4) unstable; urgency=low
* Improve detection of Net::DNS versions. (Closes: 766718)
diff -Nru spamassassin-3.4.0/debian/patches/bug_771408_perl_version spamassassin-3.4.0/debian/patches/bug_771408_perl_version
--- spamassassin-3.4.0/debian/patches/bug_771408_perl_version 1969-12-31 16:00:00.000000000 -0800
+++ spamassassin-3.4.0/debian/patches/bug_771408_perl_version 2014-11-29 14:29:29.000000000 -0800
@@ -0,0 +1,15 @@
+upstream fix for bug #771408
+Index: spamassassin-3.4.0/lib/Mail/SpamAssassin/Conf/Parser.pm
+===================================================================
+--- spamassassin-3.4.0.orig/lib/Mail/SpamAssassin/Conf/Parser.pm
++++ spamassassin-3.4.0/lib/Mail/SpamAssassin/Conf/Parser.pm
+@@ -533,6 +533,9 @@ sub handle_conditional {
+ elsif ($token eq 'version') {
+ $eval .= $Mail::SpamAssassin::VERSION." ";
+ }
++ elsif ($token eq 'perl_version') {
++ $eval .= $]." ";
++ }
+ elsif ($token =~ /^\w[\w\:]+$/) { # class name
+ my $u = untaint_var($token);
+ $eval .= '"' . $u . '" ';
diff -Nru spamassassin-3.4.0/debian/patches/series spamassassin-3.4.0/debian/patches/series
--- spamassassin-3.4.0/debian/patches/series 2014-11-22 17:10:29.000000000 -0800
+++ spamassassin-3.4.0/debian/patches/series 2014-11-29 14:29:29.000000000 -0800
@@ -7,3 +7,4 @@
97_bug720499-pod-5.18
98_sa-compile-quiet
bug_766718-net-dns-vers
+bug_771408_perl_version
--- End Message ---
--- Begin Message ---
On Sun, 2014-11-30 at 00:56 -0500, Noah Meyerhans wrote:
> Spamassassin upstream has recently introduced the ability for rule
> authors to query for the perl version, which had previously not been
> visible to rules. The intent is to allow authors to conditionally enable
> rules based on the availability of newer perl features.
Unblocked, thanks.
Regards,
Adam
--- End Message ---