Bug#771304: unblock: jscommunicator/2.0.3-1
Control: tags -1 - moreinfo
On 28/11/14 14:58, Adam D. Barratt wrote:
> Control: tags -1 + moreinfo
>
> On 2014-11-28 11:37, Daniel Pocock wrote:
>> The main reason for this unblock request:
>>
>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771299
>>
>> This ensures that users can mix-and-match JSCommunicator with newer
>> versions of JsSIP. This is the change to JSCommManager.js in the
>> debdiff.
>
> This appears to be a request for pre-approval, rather than an actual
> unblock at this point. Please make sure you mention that in future, to
> save confusion.
>
> A quick on the diff:
>
> + log: { level: "debug" }
>
> Is that intentional? It's not mentioned and doesn't seem an obvious
> consequence of the other changes.
Yes, this ensures that newer versions of JsSIP log their SIP messages to
the JavaScript console, maintaining existing behavior. The existing
version of JsSIP in Debian is logging everything be default even without
that setting.
I've just made the upload to unstable.
Reply to: