Bug#771236: please unblock xchat 2.8.8-7.3 or maybe remove
Hi Sebastian,
On Thu, Nov 27, 2014 at 1:49 PM, Sebastian Andrzej Siewior
<sebastian@breakpoint.cc> wrote:
> Package: release.debian.org
> User: release.debian.org@packages.debian.org
> Usertags: unblock
>
> Please unblock package xchat. Its been 16 days in unstable after an NMU
> upload by Sven Hoexter. Sven fixed #766005 (severity important) which
> allows users to connect via SSL to IRC servers which have SSLv3
> disabled.
> It would be nice to have this in Jessie. The alternative would be to
> use Hexchat. That one is a xchat fork and seems to have more active
> upstream (last release on 28-Aug-2010 for xchat vs 25 Nov 2014 for
> Hexchat) and it leads to the question why to keep xchat.
Please don't forget to attach a debdiff as per jessie's freeze policy
[1]. Anyways, for the release team's convenience, here it is.
Regards,
Vincent
[1] https://release.debian.org/jessie/freeze_policy.html
diff -Nru xchat-2.8.8/debian/changelog xchat-2.8.8/debian/changelog
--- xchat-2.8.8/debian/changelog 2014-10-13 12:57:31.000000000 -0700
+++ xchat-2.8.8/debian/changelog 2014-11-07 01:56:49.000000000 -0800
@@ -1,3 +1,11 @@
+xchat (2.8.8-7.3) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Add debian/patches/68_dont_force_sslv3.patch.
+ Provided via LP: #1381484. (Closes: #766005)
+
+ -- Sven Hoexter <hoexter@debian.org> Fri, 07 Nov 2014 10:55:27 +0100
+
xchat (2.8.8-7.2) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru xchat-2.8.8/debian/patches/68_dont_force_sslv3.patch
xchat-2.8.8/debian/patches/68_dont_force_sslv3.patch
--- xchat-2.8.8/debian/patches/68_dont_force_sslv3.patch 1969-12-31
16:00:00.000000000 -0800
+++ xchat-2.8.8/debian/patches/68_dont_force_sslv3.patch 2014-11-07
05:31:25.000000000 -0800
@@ -0,0 +1,33 @@
+Description: Don't force the use of SSLv3
+Author: Marc Deslauriers <marc.deslauriers@canonical.com>
+Bug: http://sourceforge.net/p/xchat/bugs/1598/
+Bug-Ubuntu: https://bugs.launchpad.net/xchat-gnome/+bug/1381484
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=766005
+Forwarded: yes
+
+---
+ src/common/ssl.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+Index: b/src/common/ssl.c
+===================================================================
+--- a/src/common/ssl.c
++++ b/src/common/ssl.c
+@@ -70,7 +70,7 @@ _SSL_context_init (void (*info_cb_func),
+
+ SSLeay_add_ssl_algorithms ();
+ SSL_load_error_strings ();
+- ctx = SSL_CTX_new (server ? SSLv3_server_method() : SSLv3_client_method ());
++ ctx = SSL_CTX_new (server ? SSLv23_server_method() :
SSLv23_client_method ());
+
+ SSL_CTX_set_session_cache_mode (ctx, SSL_SESS_CACHE_BOTH);
+ SSL_CTX_set_timeout (ctx, 300);
+@@ -281,7 +281,7 @@ _SSL_socket (SSL_CTX *ctx, int sd)
+ __SSL_critical_error ("SSL_new");
+
+ SSL_set_fd (ssl, sd);
+- if (ctx->method == SSLv3_client_method())
++ if (ctx->method == SSLv23_client_method())
+ SSL_set_connect_state (ssl);
+ else
+ SSL_set_accept_state(ssl);
diff -Nru xchat-2.8.8/debian/patches/series xchat-2.8.8/debian/patches/series
--- xchat-2.8.8/debian/patches/series 2014-10-13 12:58:48.000000000 -0700
+++ xchat-2.8.8/debian/patches/series 2014-11-07 01:52:49.000000000 -0800
@@ -25,3 +25,4 @@
65_save_sound.patch
66_load_libnotify4.patch
67_configure_with_gmodule.patch
+68_dont_force_sslv3.patch
\ No newline at end of file
Reply to: