[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#770953: marked as done (unblock: openstack-debian-images/1.1)

Your message dated Tue, 25 Nov 2014 18:53:53 +0000
with message-id <20141125185353.GB3086@lupin.home.powdarrmonkey.net>
and subject line Re: Bug#770953: unblock: openstack-debian-images/1.1
has caused the Debian Bug report #770953,
regarding unblock: openstack-debian-images/1.1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
770953: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770953
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi,

As per pre-approval, I have added the -o compat=1.0 option to
openstack-debian-images when building with a Qemu version greter than 1.0.
This allows to build OpenStack Debian images which are compatible with older
Qemu, which is often what public cloud providers are still using.

Debdiff attached.

Please unblock openstack-debian-images/1.1.

Cheers,

Thomas Goirand (zigo)

diff -Nru openstack-debian-images-1.0/build-openstack-debian-image openstack-debian-images-1.1/build-openstack-debian-image
--- openstack-debian-images-1.0/build-openstack-debian-image	2014-10-25 07:53:14.000000000 +0000
+++ openstack-debian-images-1.1/build-openstack-debian-image	2014-11-25 13:47:17.000000000 +0000
@@ -417,11 +417,11 @@
 	install-mbr ${AMI_NAME}
 fi
 
-#QEMU_VERSION=`qemu-img --help | head -n 1 | cut -d" " -f3 | cut -d"," -f1`
-#if dpkg --compare-versions ${QEMU_VERSION} gt 1.0 ; then
-#	OTHER_QEMU_IMG_OPTIONS=" -O compat=0.10"
-#else
+QEMU_VERSION=`qemu-img --help | head -n 1 | cut -d" " -f3 | cut -d"," -f1`
+if dpkg --compare-versions ${QEMU_VERSION} gt 1.0 ; then
+	OTHER_QEMU_IMG_OPTIONS=" -o compat=0.10"
+else
 	OTHER_QEMU_IMG_OPTIONS=""
-#fi
+fi
 
 qemu-img convert -c -f raw ${AMI_NAME}${OTHER_QEMU_IMG_OPTIONS} -O qcow2 ${QCOW2_NAME}
diff -Nru openstack-debian-images-1.0/debian/changelog openstack-debian-images-1.1/debian/changelog
--- openstack-debian-images-1.0/debian/changelog	2014-10-25 07:53:14.000000000 +0000
+++ openstack-debian-images-1.1/debian/changelog	2014-11-25 13:47:17.000000000 +0000
@@ -1,3 +1,9 @@
+openstack-debian-images (1.1) unstable; urgency=medium
+
+  * Fixed compat option for newer qemu (Closes: #770943).
+
+ -- Thomas Goirand <zigo@debian.org>  Fri, 21 Nov 2014 13:48:26 +0800
+
 openstack-debian-images (1.0) unstable; urgency=medium
 
   * Fixed the sudoers file to support the --login option. (Closes: #766234)

--- End Message ---
--- Begin Message --- 
Control: merge -1 770429
Control: close -1

On Tue, Nov 25, 2014 at 09:52:03PM +0800, Thomas Goirand wrote:
> As per pre-approval, I have added the -o compat=1.0 option to
> openstack-debian-images when building with a Qemu version greter than 1.0.
> This allows to build OpenStack Debian images which are compatible with older
> Qemu, which is often what public cloud providers are still using.

Unblocked, thanks.

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: