[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#770429: marked as done (Pre-approval for unblock: openstack-debian-images/1.0.0)



Your message dated Fri, 21 Nov 2014 13:21:07 +0000
with message-id <c423deb6bd92bdb8287b8b7ff3b9d2a7@hogwarts.powdarrmonkey.net>
and subject line Re: Bug#770429: Pre-approval for unblock:  openstack-debian-images/1.0.0
has caused the Debian Bug report #770429,
regarding Pre-approval for unblock: openstack-debian-images/1.0.0
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
770429: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770429
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

As per Neils request, here's a copy of my last mail asking for pre-approval
for uploading openstack-debian-images/1.0.0.

Dear release team,

The package openstack-debian-images, when used with newer version of
Qemu, may generate images which aren't useable on some cloud providers.
The way to fix it is to use the following option:
"-o compat=0.10"

Without this, some users may not understand why their image isn't
useable in some public clouds.

Unfortunately, I didn't understand why when I was using it, it was
failing. Until now: I was using big -O instead of lowercase -o. Since I
have found out, I'd like to upload a fixed version of
openstack-debian-images to Sid and have it in Jessie.

Please let me know if the attached patch is ok, and if I can upload a
new version of openstack-debian-images in Sid. Diff attached.

Cheers,

Thomas Goirand (zigo)
diff --git a/build-openstack-debian-image b/build-openstack-debian-image
index 0489bc4..f6d4fd7 100755
--- a/build-openstack-debian-image
+++ b/build-openstack-debian-image
@@ -417,11 +417,11 @@ if [ "${AUTOMATIC_RESIZE}" = "yes" ] ; then
 	install-mbr ${AMI_NAME}
 fi
 
-#QEMU_VERSION=`qemu-img --help | head -n 1 | cut -d" " -f3 | cut -d"," -f1`
-#if dpkg --compare-versions ${QEMU_VERSION} gt 1.0 ; then
-#	OTHER_QEMU_IMG_OPTIONS=" -O compat=0.10"
-#else
+QEMU_VERSION=`qemu-img --help | head -n 1 | cut -d" " -f3 | cut -d"," -f1`
+if dpkg --compare-versions ${QEMU_VERSION} gt 1.0 ; then
+	OTHER_QEMU_IMG_OPTIONS=" -o compat=0.10"
+else
 	OTHER_QEMU_IMG_OPTIONS=""
-#fi
+fi
 
 qemu-img convert -c -f raw ${AMI_NAME}${OTHER_QEMU_IMG_OPTIONS} -O qcow2 ${QCOW2_NAME}
diff --git a/debian/changelog b/debian/changelog
index 2c38f45..d024639 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+openstack-debian-images (1.1) unstable; urgency=medium
+
+  * Fixed compat option for newer qemu.
+
+ -- Thomas Goirand <zigo@debian.org>  Fri, 21 Nov 2014 13:48:26 +0800
+
 openstack-debian-images (1.0) unstable; urgency=medium
 
   * Fixed the sudoers file to support the --login option. (Closes: #766234)

--- End Message ---
--- Begin Message ---
Control: tag -1 confirmed

On 2014-11-21 08:15, Thomas Goirand wrote:
The package openstack-debian-images, when used with newer version of
Qemu, may generate images which aren't useable on some cloud providers.
The way to fix it is to use the following option:
"-o compat=0.10"

Without this, some users may not understand why their image isn't
useable in some public clouds.

Unfortunately, I didn't understand why when I was using it, it was
failing. Until now: I was using big -O instead of lowercase -o. Since I
have found out, I'd like to upload a fixed version of
openstack-debian-images to Sid and have it in Jessie.

Please let me know if the attached patch is ok, and if I can upload a
new version of openstack-debian-images in Sid. Diff attached.

If you rate the bug to be severity >=important, then yes please go ahead.

--
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

<directhex> i have six years of solaris sysadmin experience, from
            8->10. i am well qualified to say it is made from bonghits
			layered on top of bonghits

--- End Message ---

Reply to: