[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#770395: marked as done (unblock: python-flickrapi/1.2-3.1 (adjust for new Flickr web API SSL requirement))

Your message dated Thu, 20 Nov 2014 22:59:46 +0000
with message-id <20141120225946.GR6216@lupin.home.powdarrmonkey.net>
and subject line Re: Bug#770395: unblock: python-flickrapi/1.2-3.1 (adjust for new Flickr web API SSL requirement)
has caused the Debian Bug report #770395,
regarding unblock: python-flickrapi/1.2-3.1 (adjust for new Flickr web API SSL requirement)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
770395: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770395
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertags: unblock
Severity: normal

Please unblock the python-flickrapi package to make it able to talk to
the Flickr web API (bug #769722).

To get the patched source building I had to add --prefix=/usr to the
rules file, and fixed a lintian warning about missing dependencies in
the process.

Here is the diff between version 1.2-3 already in testing and 1.2-3.1
in unstable.  In addition to these changes, the build changed a few
generated files in the source package:

--- python-flickrapi-1.2/debian/changelog
+++ python-flickrapi-1.2/debian/changelog
@@ -1,3 +1,14 @@
+python-flickrapi (1.2-3.1) unstable; urgency=low
+
+  * Non-maintainer upload to get module working again.
+  * Change API URLs from http to https to get them working with the
+    current Flickr API where SSL is required (Closes: #769722).
+  * Add missing ${misc:Depends} to dependency list.
+  * Add --prefix=/usr to setup run in rules file to make sure the
+    documentation end up in /usr/share/doc/, not /usr/local/share/doc/.
+
+ -- Petter Reinholdtsen <pere@debian.org>  Mon, 17 Nov 2014 21:48:46 +0100
+
 python-flickrapi (1.2-3) unstable; urgency=low
 
   * Improved package long description (closes: #531014)
diff -u python-flickrapi-1.2/debian/control python-flickrapi-1.2/debian/control
--- python-flickrapi-1.2/debian/control
+++ python-flickrapi-1.2/debian/control
@@ -13,7 +13,7 @@
 Package: python-flickrapi
 Architecture: all
 XB-Python-Version: ${python:Versions}
-Depends: ${python:Depends},
+Depends: ${python:Depends}, ${misc:Depends}
 Description: Flickr API wrapper for Python
  Python-flickrapi is a complete and easy to use Python
  module for interfacing with the Flickr API (see
diff -u python-flickrapi-1.2/debian/rules python-flickrapi-1.2/debian/rules
--- python-flickrapi-1.2/debian/rules
+++ python-flickrapi-1.2/debian/rules
@@ -21,7 +21,7 @@
 	dh_installdirs
 	set -e; \
 	for python in $(PYVERS); do \
-	    $$python setup.py install --root=$(d);\
+	    $$python setup.py install --root=$(d) --prefix=/usr ;\
 	done
 
 binary-indep: build install
diff -u python-flickrapi-1.2/debian/changelog python-flickrapi-1.2/debian/changelog
--- python-flickrapi-1.2.orig/flickrapi/__init__.py
+++ python-flickrapi-1.2/flickrapi/__init__.py
@@ -386,7 +386,7 @@
         if self.cache and self.cache.get(post_data):
             return self.cache.get(post_data)
 
-        url = "http://"; + FlickrAPI.flickr_host + FlickrAPI.flickr_rest_form
+        url = "https://"; + FlickrAPI.flickr_host + FlickrAPI.flickr_rest_form
         flicksocket = urllib.urlopen(url, post_data)
         reply = flicksocket.read()
         flicksocket.close()
@@ -440,7 +440,7 @@
                     "frob": frob,
                     "perms": perms})
 
-        return "http://%s%s?%s"; % (FlickrAPI.flickr_host, \
+        return "https://%s%s?%s"; % (FlickrAPI.flickr_host, \
             FlickrAPI.flickr_auth_form, encoded)
 
     def web_login_url(self, perms):
@@ -454,7 +454,7 @@
                     "api_key": self.api_key,
                     "perms": perms})
 
-        return "http://%s%s?%s"; % (FlickrAPI.flickr_host, \
+        return "https://%s%s?%s"; % (FlickrAPI.flickr_host, \
             FlickrAPI.flickr_auth_form, encoded)
 
     def __extract_upload_response_format(self, kwargs):
@@ -578,7 +578,7 @@
         
         if self.secret:
             kwargs["api_sig"] = self.sign(kwargs)
-        url = "http://%s%s"; % (FlickrAPI.flickr_host, form_url)
+        url = "https://%s%s"; % (FlickrAPI.flickr_host, form_url)
 
         # construct POST data
         body = Multipart()

-- 
Happy hacking
Petter Reinholdtsen

--- End Message ---
--- Begin Message --- 
On Thu, Nov 20, 2014 at 11:54:10PM +0100, Petter Reinholdtsen wrote:
> Please unblock the python-flickrapi package to make it able to talk to
> the Flickr web API (bug #769722).
> 
> To get the patched source building I had to add --prefix=/usr to the
> rules file, and fixed a lintian warning about missing dependencies in
> the process.
> 
> Here is the diff between version 1.2-3 already in testing and 1.2-3.1
> in unstable.  In addition to these changes, the build changed a few
> generated files in the source package:

Already unblocked by the unblocking machine we call adsb.

(he's human really. honest.)

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: