[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#769813: marked as done (pre-approval: unblock: hdapsd/1:20141024-2)

Your message dated Thu, 20 Nov 2014 18:59:11 +0000
with message-id <20141120185911.GT6216@lupin.home.powdarrmonkey.net>
and subject line Re: Bug#769813: pre-approval: unblock: hdapsd/1:20141024-2
has caused the Debian Bug report #769813,
regarding pre-approval: unblock: hdapsd/1:20141024-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
769813: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769813
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi,

the current version of hdapsd in testing (1:20141024-1) behaves differently
when installed on systemd-systems compared to sysvinit-systems: it is not
started automatically as the unit is shipped in "disabled" state.
Full blame on me for not properly checking my memory against the actual
package.

I would like to upload -2 to fix this. And if possible, update documentation
and debian/watch in the same upload. The relevant diff would be like this:

diff --git a/debian/README.Debian b/debian/README.Debian
index 97ea7cf..f914834 100644
--- a/debian/README.Debian
+++ b/debian/README.Debian
@@ -1,6 +1,16 @@
 hdapsd for Debian
 -----------------
 
+disable hdapsd
+==============
+
+hdapsd can be disabled on boot, if you want to start it manually.
+
+To disable hdapsd under systemd, use “systemctl disable hdapsd.service”.
+For inits using the init.d scripts, adjust /etc/default/hdapsd to have
+  START=no
+in it.
+
 hdapsd with kernels <= 2.6.27
 =============================
 
diff --git a/debian/rules b/debian/rules
index fdbeae1..a7c6726 100755
--- a/debian/rules
+++ b/debian/rules
@@ -14,10 +14,3 @@ override_dh_auto_install:
 override_dh_auto_clean:
        dh_auto_clean
        rm -f $(CURDIR)/misc/*.service
-
-override_dh_systemd_enable:
-       # Do not enable the file by default on purpose.
-       # The user should enable it only after making sure the configuration is
-       # appropriate for his/her computer.
-       # This corresponds to START=no in /etc/default/hdapsd
-       dh_systemd_enable --no-enable
diff --git a/debian/watch b/debian/watch
index a7f75b4..b9ae217 100644
--- a/debian/watch
+++ b/debian/watch
@@ -1,3 +1,2 @@
 version=3
-opts="filenamemangle=s/(?:.*)?v?(\d[\d\.]*)\.tar\.gz/hdapsd-$1.tar.gz/" \
- https://github.com/evgeni/hdapsd/tags (?:.*/)?v?(\d[\d\.]*)\.tar\.gz
+https://github.com/evgeni/hdapsd/releases .*/download/.*/hdapsd-(\d[\d\.]*)\.tar\.gz

Does this sound reasonable for you?

Greets
Evgeni

--- End Message ---
--- Begin Message --- 
On Thu, Nov 20, 2014 at 12:16:52AM +0100, Evgeni Golov wrote:
> On 11/17/2014 08:42 AM, Jonathan Wiltshire wrote:
> > Control: tag -1 confirmed
> 
> Thanks, I have uploaded -2 yesterday, but forgot to ping here.
> > 
> > On Mon, Nov 17, 2014 at 08:06:59AM +0100, Evgeni Golov wrote:
> >> > On 11/16/2014 10:15 PM, Jonathan Wiltshire wrote:
> >>> > > Control: tag -1 moreinfo
> >>> > > 
> >>> > > On Sun, Nov 16, 2014 at 06:24:01PM +0100, Evgeni Golov wrote:
> >>>> > >> +To disable hdapsd under systemd, use “systemctl disable hdapsd.service”.
> >>>> > >> +For inits using the init.d scripts, adjust /etc/default/hdapsd to have
> >>>> > >> +  START=no
> >>>> > >> +in it.
> >>> > > 
> >>> > > We have update-rc.d, no?
> >> > 
> >> > Yes we do. So how about:
> >> > 
> >> > To disable hdapsd under systemd, use “systemctl disable hdapsd.service”.
> >> > For inits using the init.d scripts, use “update-rc.d hdapsd disable” or
> >> > adjust /etc/default/hdapsd to have “START=no” in it.
> > Hm, well, my point was to get rid of the setting a flag in a defaults file
> > bit, but ok. Having a standard (and programmable) interface is way better
> > than having to manipulate defaults.
> 
> Sure, but the defaults hack was there since the beginning and I did not
> want to think about replacing it mid-freeze, it's on the Zurg-TODO-list
> though.

Unblocked.

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: