[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#770305: marked as done (unblock: libeatmydata/82-4)

Your message dated Thu, 20 Nov 2014 18:25:52 +0000
with message-id <20141120182551.GQ6216@lupin.home.powdarrmonkey.net>
and subject line Re: Bug#770305: unblock: libeatmydata/82-4
has caused the Debian Bug report #770305,
regarding unblock: libeatmydata/82-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
770305: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770305
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package libeatmydata

This upload fixes a pointless FTBFS on !linux, due to a missing build
dependency, used only during tests. Given that eatmydata worked fine in the past
on this arches, I see no point on block it on those arches.
Moreover it add a Pre-Depends line on multiarch-support, something that should
be RC.

Full debdiff follows.

diff -Nru libeatmydata-82/debian/changelog libeatmydata-82/debian/changelog
--- libeatmydata-82/debian/changelog    2014-11-09 22:36:54.000000000 +0100
+++ libeatmydata-82/debian/changelog    2014-11-19 22:48:02.000000000 +0100
@@ -1,3 +1,16 @@
+libeatmydata (82-4) unstable; urgency=low
+
+  [ Mattia Rizzolo ]
+  * [c6fde16] Fix FTBFS on hurd-i386 and kfreebsd-* due to missing strace (used
+    by the test suite) (Closes: #769605).
+
+  [ Thorsten Glaser ]
+  * [8c41772] Add missing Pre-Depends on multiarch-support
+
+  * Upload sponsored by Petter Reinholdtsen.
+
+ -- Mattia Rizzolo <mattia@mapreri.org>  Wed, 19 Nov 2014 22:41:45 +0100
+
 libeatmydata (82-3) unstable; urgency=low
 
   * debian/patches/bug-702711.patch:
diff -Nru libeatmydata-82/debian/control libeatmydata-82/debian/control
--- libeatmydata-82/debian/control  2014-11-09 12:06:58.000000000 +0100
+++ libeatmydata-82/debian/control  2014-11-19 22:48:02.000000000 +0100
@@ -36,6 +36,7 @@
 
 Package: libeatmydata1
 Architecture: any
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends},
          ${shlibs:Depends}
 Breaks: eatmydata (<< 82-1)
diff -Nru libeatmydata-82/debian/patches/series libeatmydata-82/debian/patches/series
--- libeatmydata-82/debian/patches/series   2014-11-08 14:45:40.000000000 +0100
+++ libeatmydata-82/debian/patches/series   2014-11-19 22:48:02.000000000 +0100
@@ -1,3 +1,4 @@
 executable-not-elf-or-script.patch
 multiarch-issue.patch
 bug-702711.patch
+tests
diff -Nru libeatmydata-82/debian/patches/tests libeatmydata-82/debian/patches/tests
--- libeatmydata-82/debian/patches/tests    1970-01-01 01:00:00.000000000 +0100
+++ libeatmydata-82/debian/patches/tests    2014-11-19 22:48:02.000000000 +0100
@@ -0,0 +1,16 @@
+--- a/test_run.sh
++++ b/test_run.sh
+@@ -9,6 +9,13 @@
+ # COPYING file in the root project directory for full text.
+ #
+ 
++CHECKOUT=$(which strace)
++CHECKRET="$?"
++if [ ! "$CHECKRET" -eq 0 ];then
++    echo "Could not find strace. Not running tests, but marking them as pass."
++    exit 0
++fi
++
+ # Get filename we want to run without path
+ name=`echo $1 | sed 's/.*\/\(libeatmydata\/.*[^\/]*\)$/\1/'`
+ 



unblock libeatmydata/82-4

-- 
regards,
						Mattia Rizzolo

GPG Key: 4096R/B9444540	http://goo.gl/I8TMB
more about me:		http://mapreri.org
Launchpad User:		https://launchpad.net/~mapreri
Ubuntu Wiki page:	https://wiki.ubuntu.com/MattiaRizzolo

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
On Thu, Nov 20, 2014 at 12:24:07PM +0100, Mattia Rizzolo wrote:
> This upload fixes a pointless FTBFS on !linux, due to a missing build
> dependency, used only during tests. Given that eatmydata worked fine in the past
> on this arches, I see no point on block it on those arches.
> Moreover it add a Pre-Depends line on multiarch-support, something that should
> be RC.

Unblocked.

As a general thing, please take care not be sloppy with your uploads, for example
the new patch not having the same suffix as the others, and spacing in your 'if'
statement.

> +  * Upload sponsored by Petter Reinholdtsen.
> +
> + -- Mattia Rizzolo <mattia@mapreri.org>  Wed, 19 Nov 2014 22:41:45 +0100

Hmm.

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: