[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#769922: marked as done (unblock: python-pip/1.5.6-3)

Your message dated Mon, 17 Nov 2014 22:23:23 +0100
with message-id <546A674B.9060603@thykier.net>
and subject line Re: Bug#769922: unblock: python-pip/1.5.6-3
has caused the Debian Bug report #769922,
regarding unblock: python-pip/1.5.6-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
769922: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769922
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package python-pip

unblock python-pip/1.5.6-3

This is a pre-emptive request for an upload fixing important bug
#751827.

The bug is that pip uninstall doesn't work inside virtualenvs (which is
one of the few times it makes sense to use pip on a Debian system).
As I said in my bug comment:

It looks like the story is:
1. Debian patched setuptools/distribute to not include the Python
   version in egg-info dirs. There is no bug I can see that tracks this.
2. pip then implemented the same mangling, after un-installation trouble
   was reported in #562544.
3. pip upstream implemented a workaround, themselves
   https://github.com/pypa/pip/commit/0d60e37273c587237cd2f0678ecf19005d49cea7
   and filed #618367 about Debian's original patch.

This bug arises because the setuptools patch from 1 doesn't mangle the
name, inside a virtualenv, but the pip patch from 2 does. And the
solution in 3 was masked by the patch in 2.

So, my solution to this is to drop Debian's patch to pip.

Proposed debdiff:

diff -Nru python-pip-1.5.6/debian/changelog python-pip-1.5.6/debian/changelog
--- python-pip-1.5.6/debian/changelog	2014-06-06 09:27:11.000000000 -0700
+++ python-pip-1.5.6/debian/changelog	2014-11-16 22:28:09.000000000 -0800
@@ -1,3 +1,12 @@
+python-pip (1.5.6-3) UNRELEASED; urgency=medium
+
+  * Team upload.
+  * Remove d/patches/format_egg_string.patch. This was worked around,
+    upstream, in 1.0. And this patch now breaks pip uninstall in virtualenvs.
+    (Closes: #751827)
+
+ -- Stefano Rivera <stefanor@debian.org>  Sun, 16 Nov 2014 22:21:35 -0800
+
 python-pip (1.5.6-2) unstable; urgency=medium
 
   * Team upload.
diff -Nru python-pip-1.5.6/debian/patches/format_egg_string.patch python-pip-1.5.6/debian/patches/format_egg_string.patch
--- python-pip-1.5.6/debian/patches/format_egg_string.patch	2014-03-25 08:32:43.000000000 -0700
+++ python-pip-1.5.6/debian/patches/format_egg_string.patch	1969-12-31 16:00:00.000000000 -0800
@@ -1,15 +0,0 @@
-Description: use the same .egg string format than Debian python-setuptools
-Author: Carl Chenet <chaica@ohmytux.com>
-Bug-Debian: http://bugs.debian.org/562544
-
---- a/pip/req.py
-+++ b/pip/req.py
-@@ -508,7 +508,7 @@
-         paths_to_remove = UninstallPathSet(dist)
- 
-         pip_egg_info_path = os.path.join(dist.location,
--                                         dist.egg_name()) + '.egg-info'
-+                                dist.egg_name().split('-py')[0]) + '.egg-info'
-         dist_info_path = os.path.join(dist.location,
-                                       '-'.join(dist.egg_name().split('-')[:2])
-                                       ) + '.dist-info'
diff -Nru python-pip-1.5.6/debian/patches/series python-pip-1.5.6/debian/patches/series
--- python-pip-1.5.6/debian/patches/series	2014-06-03 15:50:38.000000000 -0700
+++ python-pip-1.5.6/debian/patches/series	2014-11-16 22:21:12.000000000 -0800
@@ -1,4 +1,3 @@
-format_egg_string.patch
 de-vendorize.patch
 use-venv-wheels.patch
 better-error-message.patch

--- End Message ---
--- Begin Message --- 
On 2014-11-17 22:15, Stefano Rivera wrote:
> Hi Niels (2014.11.17_21:14:55_+0200)
>> Looks good, please upload and let us know when it has been accepted into
>> unstable.
> 
> Was accepted a couple of hours ago.
> 
> Thanks,
> 
> SR
> 

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: