[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#769371: marked as done (unblock: umockdev/0.8.8-2)



Your message dated Thu, 13 Nov 2014 05:42:46 +0000
with message-id <1415857366.23631.4.camel@adam-barratt.org.uk>
and subject line Re: Bug#769371: unblock: umockdev/0.8.8-2
has caused the Debian Bug report #769371,
regarding unblock: umockdev/0.8.8-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
769371: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769371
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package umockdev

Version 0.8.8-1 of umockdev failed to build on arm64 with a testsuite failure
and as a result we currently have an out of data umockdev in arm64 testing.

The bug was traced to udevadm producing debug output on stderr when the debug
kernel command line parameter is in use (as appears to be the case on the arm64
boxes). Version 0.8.8-2 modifies the test to ignore stderr.

A debdiff is attached.

unblock umockdev/0.8.8-2

-- System Information:
Debian Release: 6.0.3
  APT prefers oldstable-proposed-updates
  APT policy: (500, 'oldstable-proposed-updates'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -Nru umockdev-0.8.8/debian/changelog umockdev-0.8.8/debian/changelog
--- umockdev-0.8.8/debian/changelog	2014-09-22 07:41:46.000000000 +0000
+++ umockdev-0.8.8/debian/changelog	2014-11-12 09:21:56.000000000 +0000
@@ -1,3 +1,13 @@
+umockdev (0.8.8-2) unstable; urgency=medium
+
+  * Add 00git_ignore_udev_debug.patch: Ignore stderr from udevadm info, to
+    avoid udev debug message spew on stderr if udev debugging is enabled. In
+    particular, this works around #769228 which causes an FTBFS on ARM.
+    (Closes: #767909)
+  * Bump Standards-Version to 3.9.6 (no changes necessary).
+
+ -- Martin Pitt <mpitt@debian.org>  Wed, 12 Nov 2014 10:21:52 +0100
+
 umockdev (0.8.8-1) unstable; urgency=medium
 
   * New upstream bug fix release which fixes test failures.
diff -Nru umockdev-0.8.8/debian/control umockdev-0.8.8/debian/control
--- umockdev-0.8.8/debian/control	2014-09-22 07:41:46.000000000 +0000
+++ umockdev-0.8.8/debian/control	2014-11-12 09:21:56.000000000 +0000
@@ -23,7 +23,7 @@
 Homepage: https://github.com/martinpitt/umockdev/
 Vcs-Git: git://git.debian.org/git/collab-maint/umockdev.git
 Vcs-Browser: http://git.debian.org/?p=collab-maint/umockdev.git
-Standards-Version: 3.9.5
+Standards-Version: 3.9.6
 
 Package: umockdev
 Architecture: any
diff -Nru umockdev-0.8.8/debian/patches/00git_ignore_udev_debug.patch umockdev-0.8.8/debian/patches/00git_ignore_udev_debug.patch
--- umockdev-0.8.8/debian/patches/00git_ignore_udev_debug.patch	1970-01-01 00:00:00.000000000 +0000
+++ umockdev-0.8.8/debian/patches/00git_ignore_udev_debug.patch	2014-11-12 09:21:56.000000000 +0000
@@ -0,0 +1,41 @@
+From b6219cd671bb1b7e8f8a48a0547164d4dbaffc41 Mon Sep 17 00:00:00 2001
+From: Martin Pitt <martin.pitt@ubuntu.com>
+Date: Wed, 12 Nov 2014 10:13:06 +0100
+Subject: [PATCH] umockdev-record: Ignore stderr from udevadm info
+
+This avoids udev debug message spew on stderr if udev debugging is enabled.
+
+https://bugs.debian.org/767909
+---
+ src/umockdev-record.vala | 6 +++---
+ 2 files changed, 8 insertions(+), 3 deletions(-)
+
+diff --git a/src/umockdev-record.vala b/src/umockdev-record.vala
+index ccb4337..421932e 100644
+--- a/src/umockdev-record.vala
++++ b/src/umockdev-record.vala
+@@ -222,7 +222,7 @@ record_device(string dev)
+     debug("recording device %s", dev);
+ 
+     // we start with udevadm dump of this device, which will include all udev properties
+-    string u_out;
++    string u_out, u_err;
+     int exitcode;
+     try {
+         Process.spawn_sync(null,
+@@ -231,10 +231,10 @@ record_device(string dev)
+                            SpawnFlags.SEARCH_PATH,
+                            null,
+                            out u_out,
+-                           null,
++                           out u_err,
+                            out exitcode);
+         if (exitcode != 0)
+-            throw new SpawnError.FAILED("udevadm exited with code %i".printf(exitcode));
++            throw new SpawnError.FAILED("udevadm exited with code %i\n%s".printf(exitcode, u_err));
+     } catch (Error e) {
+         exit_error("Cannot call udevadm: %s", e.message);
+     }
+-- 
+2.1.3
+
diff -Nru umockdev-0.8.8/debian/patches/series umockdev-0.8.8/debian/patches/series
--- umockdev-0.8.8/debian/patches/series	2014-09-22 07:41:46.000000000 +0000
+++ umockdev-0.8.8/debian/patches/series	2014-11-12 09:21:56.000000000 +0000
@@ -0,0 +1 @@
+00git_ignore_udev_debug.patch

--- End Message ---
--- Begin Message ---
On Thu, 2014-11-13 at 03:31 +0000, peter green wrote:
> Please unblock package umockdev
> 
> Version 0.8.8-1 of umockdev failed to build on arm64 with a testsuite failure
> and as a result we currently have an out of data umockdev in arm64 testing.
> 
> The bug was traced to udevadm producing debug output on stderr when the debug
> kernel command line parameter is in use (as appears to be the case on the arm64
> boxes). Version 0.8.8-2 modifies the test to ignore stderr.

Unblocked.

Regards,

Adam

--- End Message ---

Reply to: