[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#768924: marked as done (unblock: thunar/1.6.3-2)

Your message dated Wed, 12 Nov 2014 14:01:22 +0100
with message-id <20141112130122.GA22041@mraw.org>
and subject line Re: Bug#768924: unblock: thunar/1.6.3-2
has caused the Debian Bug report #768924,
regarding unblock: thunar/1.6.3-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
768924: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768924
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package thunar

Hi,

Thunar in Jessie is affected by a regression due to Glib 2.42. This was
tracked as bug #763726 (opened as severity normal) and the problem was
that default application selection was broken (so double clicking on a
file in Thunar doesn't open the user-chosen application).

A patch went in the 1.6.3-2 package version, along with some
documentation/descriptions fixes.

The changelog entries are as follow and the debdiff is attached

thunar (1.6.3-2) unstable; urgency=medium

  [ Evgeni Golov ]
  * Correct Vcs-* URLs to point to anonscm.debian.org

  [ Jackson Doak ]
  * Bump standards-version to 3.9.6

  [ Yves-Alexis Perez ]
  * debian/control:
    - update long descriptions.
    - fix typo in thunar-dbg long description
  * debian/patches:
    - 02_fix-default-application-selection added, fix selection of default
      application for opening files, broken since glib 2.42.    closes: #763726

 -- Yves-Alexis Perez <corsac@debian.org>  Thu, 30 Oct 2014 11:00:02 +0100

Thanks in advance,

unblock thunar/1.6.3-2

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (450, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru thunar-1.6.3/debian/changelog thunar-1.6.3/debian/changelog
--- thunar-1.6.3/debian/changelog	2013-05-21 23:55:11.000000000 +0200
+++ thunar-1.6.3/debian/changelog	2014-10-30 11:00:04.000000000 +0100
@@ -1,3 +1,21 @@
+thunar (1.6.3-2) unstable; urgency=medium
+
+  [ Evgeni Golov ]
+  * Correct Vcs-* URLs to point to anonscm.debian.org
+
+  [ Jackson Doak ]
+  * Bump standards-version to 3.9.6
+
+  [ Yves-Alexis Perez ]
+  * debian/control:
+    - update long descriptions.
+    - fix typo in thunar-dbg long description
+  * debian/patches:
+    - 02_fix-default-application-selection added, fix selection of default
+      application for opening files, broken since glib 2.42.    closes: #763726
+
+ -- Yves-Alexis Perez <corsac@debian.org>  Thu, 30 Oct 2014 11:00:02 +0100
+
 thunar (1.6.3-1) unstable; urgency=low
 
   * New upstream release.
diff -Nru thunar-1.6.3/debian/control thunar-1.6.3/debian/control
--- thunar-1.6.3/debian/control	2013-05-21 23:54:01.000000000 +0200
+++ thunar-1.6.3/debian/control	2014-10-30 10:59:53.000000000 +0100
@@ -9,10 +9,10 @@
  libpcre3-dev, libjpeg-dev, libstartup-notification0-dev (>= 0.4), intltool,
  libxfce4util-dev (>= 4.10.0), libxfce4ui-1-dev (>= 4.10.0), libnotify-dev,
  libgudev-1.0-dev [linux-any], xfce4-panel-dev (>= 4.10.0)
-Standards-Version: 3.9.3
+Standards-Version: 3.9.6
 Homepage: http://thunar.xfce.org
-Vcs-Svn: svn://svn.debian.org/pkg-xfce/desktop/trunk/thunar/
-Vcs-Browser: http://svn.debian.org/wsvn/pkg-xfce/desktop/trunk/thunar/
+Vcs-Svn: svn://anonscm.debian.org/pkg-xfce/desktop/trunk/thunar/
+Vcs-Browser: http://anonscm.debian.org/viewvc/pkg-xfce/desktop/trunk/thunar/
 
 Package: libthunarx-2-dev
 Section: libdevel
@@ -42,24 +42,24 @@
 Breaks: thunar-data (<< 1.2.3-3)
 Replaces: thunar-data (<< 1.2.3-3)
 Description: File Manager for Xfce
- Thunar is the file manager designed to be the default file manager of Xfce 4.6
- It has been designed to be fast and easy to use.
+ Thunar is the file manager designed to be the default file manager for the
+ Xfce desktop environment. It has been designed to be fast and easy to use.
  .
- An Xfce plugin can manages the trash, if xfce4-panel is installed as well.
- Please read README.Debian for volume management stuff.
+ Also included is an Xfce panel plugin which can manage the desktop trash.
 
 Package: thunar-data
 Section: xfce
 Architecture: all
 Depends: ${misc:Depends}
 Description: Provides thunar documentation, icons and translations
- This package contains architecture-independent files for thunar.
+ This package contains architecture-independent files for thunar, the file
+ manager and file management libraries for Xfce desktop environment.
 
 Package: thunar-dbg
 Section: debug
 Architecture: any
 Priority: extra
 Depends: ${shlibs:Depends}, thunar (= ${binary:Version}), ${misc:Depends}
-Description: debugging informations for thunar
+Description: debugging information for thunar
  This package contains debugging symbols for thunar and libthunarx, the file
- manager and file management libraries for Xfce Desktop Environment.
+ manager and file management libraries for Xfce desktop environment.
diff -Nru thunar-1.6.3/debian/patches/02_fix-default-application-selection.patch thunar-1.6.3/debian/patches/02_fix-default-application-selection.patch
--- thunar-1.6.3/debian/patches/02_fix-default-application-selection.patch	1970-01-01 01:00:00.000000000 +0100
+++ thunar-1.6.3/debian/patches/02_fix-default-application-selection.patch	2014-10-30 10:59:05.000000000 +0100
@@ -0,0 +1,39 @@
+Index: Thunar-1.6.3/thunar/thunar-file.c
+===================================================================
+--- Thunar-1.6.3.orig/thunar/thunar-file.c
++++ Thunar-1.6.3/thunar/thunar-file.c
+@@ -3963,6 +3963,7 @@ thunar_file_list_get_applications (GList
+   GList       *next;
+   GList       *ap;
+   GList       *lp;
++  GAppInfo    *default_application;
+   const gchar *previous_type = NULL;
+   const gchar *current_type;
+ 
+@@ -3981,7 +3982,25 @@ thunar_file_list_get_applications (GList
+ 
+       /* determine the list of applications that can open this file */
+       if (G_UNLIKELY (current_type != NULL))
+-        list = g_app_info_get_all_for_type (current_type);
++        {
++          list = g_app_info_get_all_for_type (current_type);
++
++          /* move any default application in front of the list */
++          default_application = g_app_info_get_default_for_type (current_type, FALSE);
++          if (G_LIKELY (default_application != NULL))
++            {
++              for (ap = list; ap != NULL; ap = ap->next)
++                {
++                  if (g_app_info_equal (ap->data, default_application))
++                    {
++                      g_object_unref (ap->data);
++                      list = g_list_delete_link (list, ap);
++                      break;
++                    }
++                }
++              list = g_list_prepend (list, default_application);
++            }
++        }
+       else
+         list = NULL;
+ 
diff -Nru thunar-1.6.3/debian/patches/series thunar-1.6.3/debian/patches/series
--- thunar-1.6.3/debian/patches/series	2013-05-21 23:54:01.000000000 +0200
+++ thunar-1.6.3/debian/patches/series	2014-10-30 10:59:05.000000000 +0100
@@ -1 +1,2 @@
 01_support-non-multiarch-modules.patch
+02_fix-default-application-selection.patch

--- End Message ---
--- Begin Message --- 
Yves-Alexis Perez <corsac@debian.org> (2014-11-10):
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package thunar
> 
> Hi,
> 
> Thunar in Jessie is affected by a regression due to Glib 2.42. This was
> tracked as bug #763726 (opened as severity normal) and the problem was
> that default application selection was broken (so double clicking on a
> file in Thunar doesn't open the user-chosen application).
> 
> A patch went in the 1.6.3-2 package version, along with some
> documentation/descriptions fixes.

I guess I can live with those; unblocked, thanks.

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: