[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#769144: marked as done (unblock: requests/2.4.3-3)

Your message dated Wed, 12 Nov 2014 07:21:55 +0100
with message-id <5462FC83.6090402@thykier.net>
and subject line Re: Bug#769144: unblock: requests/2.4.3-3
has caused the Debian Bug report #769144,
regarding unblock: requests/2.4.3-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
769144: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769144
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package requests

2.4.3-3 fix RC bug #769047 that can lead to a breakage of unrelated
software.

For a complete explaination please look at this thread:
https://lists.debian.org/debian-python/2014/11/msg00001.html

I adopted Jakub Wilk's patch so I did not reworked any other patches.
This way we don't have to force users to use either
requests.packages.urllib3 or global urllib3 as import point.

This is the debdiff against requests 2.4.3-2:

diff -Nru requests-2.4.3/debian/changelog requests-2.4.3/debian/changelog
--- requests-2.4.3/debian/changelog 2014-10-23 08:53:39.000000000 +0200
+++ requests-2.4.3/debian/changelog 2014-11-11 17:32:09.000000000 +0100
@@ -1,3 +1,12 @@
+requests (2.4.3-3) unstable; urgency=medium
+
+  * debian/patches/04_make-requests.packages.urllib3-same-as-urllib3.patch
+    - Make Python import system know that requests.packages.urllib3 and
+      urllib3 are the same thing. Thanks to Jakub Wilk for the patch.
+      (Closes: #769047)
+
+ -- Daniele Tricoli <eriol@mornie.org>  Tue, 11 Nov 2014 03:28:18 +0100
+
 requests (2.4.3-2) unstable; urgency=medium
 
   * debian/patches/03_export-IncompleteRead.patch
diff -Nru requests-2.4.3/debian/patches/04_make-requests.packages.urllib3-same-as-urllib3.patch requests-2.4.3/debian/patches/04_make-requests.packages.urllib3-same-as-urllib3.patch
--- requests-2.4.3/debian/patches/04_make-requests.packages.urllib3-same-as-urllib3.patch   1970-01-01 01:00:00.000000000 +0100
+++ requests-2.4.3/debian/patches/04_make-requests.packages.urllib3-same-as-urllib3.patch   2014-11-11 03:43:50.000000000 +0100
@@ -0,0 +1,34 @@
+Description: Make Python import system know that requests.packages.urllib3 and
+urllib3 are the same thing.
+Author: Jakub Wilk <jwilk@debian.org>
+Forwarded: not-needed
+Bug-Debian: https://bugs.debian.org/769047
+Last-Update: 2014-11-05
+
+--- a/requests/__init__.py
++++ b/requests/__init__.py
+@@ -48,6 +48,24 @@
+ __license__ = 'Apache 2.0'
+ __copyright__ = 'Copyright 2014 Kenneth Reitz'
+ 
++# On Debian make Python import system know that requests.packages.urllib3
++# and urllib3 are the same thing.
++import pkgutil
++import sys
++import urllib3
++
++def _attach_namespace(package, where):
++    for loader, name, ispkg in pkgutil.walk_packages(package.__path__,
++                                                     package.__name__ + '.'):
++        try:
++            module = __import__(name)
++        except ImportError:
++            continue
++        sys.modules[where + '.' + name] = module
++
++_attach_namespace(urllib3, 'requests.packages')
++del _attach_namespace
++
+ # Attempt to enable urllib3's SNI support, if possible
+ try:
+     from urllib3.contrib import pyopenssl
diff -Nru requests-2.4.3/debian/patches/series requests-2.4.3/debian/patches/series
--- requests-2.4.3/debian/patches/series    2014-10-23 08:52:56.000000000 +0200
+++ requests-2.4.3/debian/patches/series    2014-11-11 03:43:50.000000000 +0100
@@ -1,3 +1,4 @@
 01_use-system-ca-certificates.patch
 02_use-system-chardet-and-urllib3.patch
 03_export-IncompleteRead.patch
+04_make-requests.packages.urllib3-same-as-urllib3.patch

Please consider unblocking it. Many thenks!

unblock requests/2.4.3-3

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

--- End Message ---
--- Begin Message --- 
On 2014-11-11 20:08, Daniele Tricoli wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package requests
> 
> 2.4.3-3 fix RC bug #769047 that can lead to a breakage of unrelated
> software.
> 
> For a complete explaination please look at this thread:
> https://lists.debian.org/debian-python/2014/11/msg00001.html
> 
> I adopted Jakub Wilk's patch so I did not reworked any other patches.
> This way we don't have to force users to use either
> requests.packages.urllib3 or global urllib3 as import point.
> 
> [...]

Excellent, thanks.

I have unblocked requests/2.4.3-3

~Niels

--- End Message ---
Reply to: