[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#768893: unblock: libeatmydata/82-3



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package libeatmydata.

This upload fix an imbortant bug,
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=765738
that renders the program useless in some cases. Note that that patch already got
included upstream, in the release 105 (see the debian vcs).
It also tries to fix an ftbfs on a couple of non-release arch, but it seems that
a patch it's also needed.
To kid the test suite and fix the ftbfs a simple

--- a/test_run.sh
+++ b/test_run.sh
@@ -9,6 +9,8 @@
 # COPYING file in the root project directory for full text.
 #
 
+`which strace` || exit 0
+
 # Get filename we want to run without path
 name=`echo $1 | sed 's/.*\/\(libeatmydata\/.*[^\/]*\)$/\1/'`

is enough.
Do you feel I should upload such a change, for including it in jessie?
I would be for it.


Current debdiff follows:

diff -Nru libeatmydata-82/debian/changelog libeatmydata-82/debian/changelog
--- libeatmydata-82/debian/changelog    2014-10-15 20:25:18.000000000 +0200
+++ libeatmydata-82/debian/changelog    2014-11-09 22:16:55.000000000 +0100
@@ -1,3 +1,13 @@
+libeatmydata (82-3) unstable; urgency=low
+
+  * debian/patches/bug-702711.patch:
+    + [c95e942] fix the bug #702711 also for 32 bit arches (Closes: #765738).
+    + [0167220] update headers.
+  * [3fabf6f] debian/control: build-depend on strace only on non hurd and non
+    kfreebsd systems, where it is unavailable.
+
+ -- Mattia Rizzolo <mattia@mapreri.org>  Sun, 09 Nov 2014 22:16:51 +0100
+
 libeatmydata (82-2) unstable; urgency=medium
 
   * Upload to unstable.
diff -Nru libeatmydata-82/debian/control libeatmydata-82/debian/control
--- libeatmydata-82/debian/control  2014-10-03 20:45:30.000000000 +0200
+++ libeatmydata-82/debian/control  2014-11-09 12:06:58.000000000 +0100
@@ -6,7 +6,7 @@
 Standards-Version: 3.9.6
 Build-Depends: autotools-dev,
                debhelper (>=9),
-               strace
+               strace [!hurd-any !kfreebsd-any]
 Homepage: https://launchpad.net/libeatmydata
 Vcs-Git: git://anonscm.debian.org/collab-maint/libeatmydata.git
 Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/libeatmydata.git
diff -Nru libeatmydata-82/debian/patches/bug-702711.patch libeatmydata-82/debian/patches/bug-702711.patch
--- libeatmydata-82/debian/patches/bug-702711.patch 2014-10-03 21:00:09.000000000 +0200
+++ libeatmydata-82/debian/patches/bug-702711.patch 2014-11-09 22:12:41.000000000 +0100
@@ -3,10 +3,12 @@
  called by ctors, do not return an unexpected error.
 Author: Roland Stigge <stigge@antcom.de>
 Reviewed-By: Petter Reinholdtsen <pere@hungry.com>
+Reviewed-By: Mattia Rizzolo <mattia@mapreri.org>
 Bug: https://launchpad.net/bugs/1374862
 Bug-Debian: https://bugs.debian.org/702711
+Bug-Debian: https://bugs.debian.org/765738
 Forwarded: https://launchpad.net/bugs/1374862
-Last-Update: 2014-10-03
+Last-Update: 2014-10-29
 
 --- a/libeatmydata/libeatmydata.c
 +++ b/libeatmydata/libeatmydata.c
@@ -40,4 +42,13 @@
 +  if (initing) {
        errno = EFAULT;
        return -1;
+   }
+@@ -171,7 +174,7 @@
+ 
+   /* In pthread environments the dlsym() may call our open(). */
+   /* We simply ignore it because libc is already loaded       */
+-  if (!libc_open64) {
++  if (initing) {
+       errno = EFAULT;
+       return -1;
    }

unblock libeatmydata/82-3

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
arm64
armhf
ppc64el
s390x
armel

Kernel: Linux 3.16-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-- 
regards,
						Mattia Rizzolo

GPG Key: 4096R/B9444540	http://goo.gl/I8TMB
more about me:		http://mapreri.org
Launchpad User:		https://launchpad.net/~mapreri
Ubuntu Wiki page:	https://wiki.ubuntu.com/MattiaRizzolo

Attachment: signature.asc
Description: Digital signature


Reply to: