[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#768154: marked as done (unblock: trousers/0.3.13-3)



Your message dated Wed, 5 Nov 2014 23:20:26 +0000
with message-id <20141105232026.GJ15155@lupin.home.powdarrmonkey.net>
and subject line Re: Bug#768154: unblock: trousers/0.3.13-3
has caused the Debian Bug report #768154,
regarding unblock: trousers/0.3.13-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
768154: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768154
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package trousers

The recent upload to unstable contains only the targeted fix for the
RC bug reported in #767690.

Full debdiff attached.

unblock trousers/0.3.13-3
diff -Nru trousers-0.3.13/debian/changelog trousers-0.3.13/debian/changelog
--- trousers-0.3.13/debian/changelog	2014-08-20 14:27:34.000000000 +0200
+++ trousers-0.3.13/debian/changelog	2014-11-04 15:16:06.000000000 +0100
@@ -1,3 +1,18 @@
+trousers (0.3.13-3) unstable; urgency=high
+
+  * Fix postinst script, preventing installation (Closes: #767690)
+    - The postinst script does not fail anymore if the TPM device is not
+      present, or if udev reload command fails.
+      This is typically the case in a chroot environment.
+  * Fix init script to be more robust:
+    - Test for TPM device owner and issue a warning if not matching the tss
+      user.
+    - Do not try to change uid before running tcsd, the daemon already changes
+      its uid just after starting.
+  * Urgency high, RC bug
+
+ -- Pierre Chifflier <pollux@debian.org>  Tue, 04 Nov 2014 15:11:08 +0100
+
 trousers (0.3.13-2) unstable; urgency=medium
 
   * Fix FTBFS on hurd-i386 and kfreebsd-any (Closes: #754359)
diff -Nru trousers-0.3.13/debian/trousers.init trousers-0.3.13/debian/trousers.init
--- trousers-0.3.13/debian/trousers.init	2012-06-15 12:58:08.000000000 +0200
+++ trousers-0.3.13/debian/trousers.init	2014-11-04 15:06:24.000000000 +0100
@@ -35,7 +35,15 @@
 			exit 0
 		fi
 
-		start-stop-daemon --start --quiet --oknodo --pidfile /var/run/${NAME}.pid --user ${USER} --chuid ${USER} --exec ${DAEMON} -- ${DAEMON_OPTS}
+		for tpm_dev in /dev/tpm*; do
+			TPM_OWNER=$(stat -c %U $tpm_dev)
+			if [ "x$TPM_OWNER" != "xtss" ]
+			then
+				log_warning_msg "TPM device owner for $tpm_dev is not 'tss', this can cause problems."
+			fi
+		done
+
+		start-stop-daemon --start --quiet --oknodo --pidfile /var/run/${NAME}.pid --user ${USER} --exec ${DAEMON} -- ${DAEMON_OPTS}
 		RETVAL="$?"
 		log_end_msg $RETVAL
 		[ "$RETVAL" = 0 ] && pidof $DAEMON > /var/run/${NAME}.pid
diff -Nru trousers-0.3.13/debian/trousers.postinst trousers-0.3.13/debian/trousers.postinst
--- trousers-0.3.13/debian/trousers.postinst	2014-06-29 17:31:52.000000000 +0200
+++ trousers-0.3.13/debian/trousers.postinst	2014-11-04 14:49:01.000000000 +0100
@@ -16,9 +16,9 @@
 		chmod 0700 /var/lib/tpm
 
 		# ask udev to check for new udev rules (and fix device permissions)
-		if udevadm --version > /dev/null; then
-			udevadm control --reload-rules
-			udevadm trigger --sysname-match="tpm[0-9]*"
+		if [ -e /dev/tpm0 ] && udevadm --version > /dev/null; then
+			udevadm control --reload-rules ||:
+			udevadm trigger --sysname-match="tpm[0-9]*" ||:
 		fi
 		;;
 

--- End Message ---
--- Begin Message ---
On Wed, Nov 05, 2014 at 02:37:57PM +0100, Pierre Chifflier wrote:
> Please unblock package trousers
> 
> The recent upload to unstable contains only the targeted fix for the
> RC bug reported in #767690.

Unblocked, thanks.

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

--- End Message ---

Reply to: