[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#767390: marked as done (unblock: dbconfig-common/1.8.47+nmu3 (pre-upload confirmation request))

Your message dated Fri, 31 Oct 2014 11:52:16 +0000
with message-id <20141031115216.GG9510@lupin.home.powdarrmonkey.net>
and subject line Re: Bug#767390: unblock: dbconfig-common/1.8.47+nmu3 (pre-upload confirmation request)
has caused the Debian Bug report #767390,
regarding unblock: dbconfig-common/1.8.47+nmu3 (pre-upload confirmation request)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
767390: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767390
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertags: unblock
Severity: normal
X-Debbugs-CC: 767248@bugs.debian.org

Hi Release team,

In my effort to fix RC bug 720517 in dbconfig-common via NMU (which
migrated to Jessie some days ago), I introduced a quite similar bug for
other packages, namely RC bug 767248: "dbconfig-common: removes any
permissions from generated include files on upgrade".

What I did to fix bug 720517 was to only honor request from packages to
change ownership and permissions when they install, not during updates,
in order to preserve permissions done by local administrators. This
works great for packages that ask dbconfig-common to manage the file via
ufc. However, in the current bug the trouble is that not all packages
ask dbconfig-common to register their file with ufc (I will try to
figure out if that is not a bug in itself, but that is not currently the
issue). In the case that a package does NOT ask dbconfig-common to use
ufc, the file ownership and permissions are now not correct during upgrades.

I intend to upload dbconfig-common with the attached debdiff but request
confirmation from you that you will accept this fix. If not, could you
advice on the direction you want me to take.

Paul

unblock dbconfig-common/1.8.47+nmu3

-- System Information:
Debian Release: 7.7
  APT prefers stable
  APT policy: (500, 'stable'), (99, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru dbconfig-common-1.8.47+nmu2/dbconfig-generate-include dbconfig-common-1.8.47+nmu3/dbconfig-generate-include
--- dbconfig-common-1.8.47+nmu2/dbconfig-generate-include	2014-10-13 21:05:57.000000000 +0200
+++ dbconfig-common-1.8.47+nmu3/dbconfig-generate-include	2014-10-29 16:38:09.000000000 +0100
@@ -408,6 +408,10 @@
 		ucf --debconf-ok "$tmpout" "$outputfile" >&2
 		rm -f "$tmpout"
 	else
+		# Replicate permissions of original file to temp file
+		# so it doesn't get lost
+		chmod --reference="$outputfile" "$tmpout"
+		chown --reference="$outputfile" "$tmpout"
 		mv "$tmpout" "$outputfile"
 	fi
 	check_permissions
diff -Nru dbconfig-common-1.8.47+nmu2/debian/changelog dbconfig-common-1.8.47+nmu3/debian/changelog
--- dbconfig-common-1.8.47+nmu2/debian/changelog	2014-10-13 21:31:13.000000000 +0200
+++ dbconfig-common-1.8.47+nmu3/debian/changelog	2014-10-29 16:43:27.000000000 +0100
@@ -1,3 +1,11 @@
+dbconfig-common (1.8.47+nmu3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Do not remove permissions from include files on upgrade,
+    thanks to Simon Bruder. (Closes: #767248)
+
+ -- Dominik George <nik@naturalnet.de>  Wed, 29 Oct 2014 16:38:19 +0100
+
 dbconfig-common (1.8.47+nmu2) unstable; urgency=low
 
   * Non-maintainer upload.

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
On Thu, Oct 30, 2014 at 08:44:51PM +0100, Paul Gevers wrote:
> I intend to upload dbconfig-common with the attached debdiff but request
> confirmation from you that you will accept this fix. If not, could you
> advice on the direction you want me to take.

We'll accept a (sane) working fix for a genuine problem, you don't need
pre-approval to do that in sid. Looks like there's some work to do still
though, so please reopen this bug when it's fixed and properly tested.



-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: